Re: [PATCH 6/7] gnu: Add python-ruamel.yaml.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2425 bytes --]

Hi ng0!

I've looked at this patch series and it looks good so far, except for
the two inline comments I added below.

contact.ng0@cryptolab.net writes:

> From: ng0 <ngillmann@runbox.com>
>
> * gnu/packages/python.scm (python-ruamel.yaml): New variable.
> ---
>  gnu/packages/python.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 285207543..583f57b6f 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2845,6 +2845,41 @@ object.")
>  (define-public python2-pyyaml
>    (package-with-python2 python-pyyaml))
>  
> +(define-public python-ruamel.yaml
> +  (package
> +    (name "python-ruamel.yaml")
> +    (version "0.12.14")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "ruamel.yaml" version))
> +       (sha256
> +        (base32
> +         "1w23nqswsq083xc0qpkw764n1a4v5g9p4fz1jkp6xbrzr9mrkqp7"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(;; Otherwise it complains that you have to do "pypi install ."
> +       #:configure-flags (list "--single-version-externally-managed"

Have you tried removing this "--single-version-externally-managed" flag
when using the latest Python build system? I believe it is always used
now. See commit 7db40bce58.

> +                               "--record=ruamel.yaml.txt")))
> +    (inputs
> +     `(("python-typing" ,python-typing)))
> +    (home-page "https://bitbucket.org/ruamel/yaml")
> +    (synopsis "YAML 1.2 loader/dumper package for Python")
> +    (description
> +     "@code{ruamel.yaml} is a YAML 1.2 parser/emitter that supports roundtrip
> +preservation of comments, seq/map flow style, and map key order.")
> +    (license license:expat)))
> +
> +(define-public python2-ruamel.yaml
> +  (package (inherit (package-with-python2
> +                     (strip-python2-variant python-ruamel.yaml)))
> +    (name "python2-ruamel.yaml")
> +    (inputs
> +     `(("python2-ruamel.ordereddict" ,python2-ruamel.ordereddict)
> +       ("python2-typing" ,python2-typing)))
> +    (native-inputs
> +     `(("python2-setuptools" ,python2-setuptools)))))

Is this really required? Setuptools now comes with our python packages,
this was also introduced by Hartmut as part of the new Python build
system.

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]