Re: java: switch to icedtea-8 as default JDK

[Chris Marusich <cmmarusich@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 12456 bytes --]

Gábor Boskovits <boskovits@gmail.com> writes:

> Hello!
>
> I've just checked the current build status of packages on hyrda. I could
> filter out a few that currently seems not to build anyway, we might try to
> fix those first.
>
> I'll send a quick list:
>
> *java-htsjdk@1.129 -> newer version (2.3.0) in master, does not build;
> java-testng@6.12
> *java-plexus-container-default@1.7.1 -> does not build; java-testng@6.12
> *kodi@18.0_alpha-6-f22d62d -> does not build; unbound 1.6.7
> *java-eclipse-jetty-servlet@9.4.6 -> does not build;
> java-eclipse-jetty-security-9.2.22
> *java-eclipse-jetty-servlet@9.2.22 -> does not build;
> java-eclipse-jetty-security-9.4.6
>
> The first one with the specific version does build, to be clear, but the
> newer version does not.
> I've extracted the log segment of those failures:
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> java-testng@6.12 - log extract:
> TestNG
> Total tests run: 1517, Failures: 1, Skips: 0
> ===============================================
>
> Failures in <suite> :TestNG, <test> :Parallelization
> test.thread.parallelization.ParallelByMethodsTestCase4Scenario1.verifyThatTestMethodsRunInParallelThreads()
> StackTrace:
>  java.lang.AssertionError: Expected 6 test method start event logs to be in
> a block of methods executing in parallel. Found an event log of a different
> type in the block being processed: [EventLog{Event:
> LISTENER_TEST_METHOD_START, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodB, Time of
> event: 1511159025654, Thread ID: 5556}, EventLog{Event:
> TEST_METHOD_EXECUTION, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodB, Data
> provider param: paramThree, Time of event: 1511159026154, Thread ID: 5556},
> EventLog{Event: LISTENER_TEST_METHOD_START, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodA, Time of
> event: 1511159026244, Thread ID: 5550}, EventLog{Event:
> LISTENER_TEST_METHOD_START, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodF, Time of
> event: 1511159026244, Thread ID: 5560}, EventLog{Event:
> LISTENER_TEST_METHOD_START, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodC, Time of
> event: 1511159026244, Thread ID: 5552}, EventLog{Event:
> LISTENER_TEST_METHOD_START, Suite: TestSuiteC, Test:
> TestSuiteC-FourTestClassTest, Class:
> test.thread.parallelization.sample.TestClassBSixMethodsWithDataProviderOnAllMethodsAndNoDepsSample,
> Class instance hash code: 2118912967, Method name: testMethodE, Time of
> event: 1511159026244, Thread ID: 5558}] expected [true] but found [false]
> at
> test.thread.parallelization.BaseParallelizationTest.verifyEventTypeForEventsLogs(Unknown
> Source)
> at
> test.thread.parallelization.BaseParallelizationTest.verifySimultaneousTestMethodListenerStartEvents(Unknown
> Source)
> at
> test.thread.parallelization.BaseParallelizationTest.verifySimultaneousTestMethodListenerStartEvents(Unknown
> Source)
> at
> test.thread.parallelization.BaseParallelizationTest.verifyParallelTestMethodsWithNonParallelDataProvider(Unknown
> Source)
> at
> test.thread.parallelization.ParallelByMethodsTestCase4Scenario1.verifyThatTestMethodsRunInParallelThreads(Unknown
> Source)
> ... Removed 27 stack frames
>
> phase `check' failed after 282.9 seconds
>
> Requires further investigation.
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> unbound@1.6.7 - log extract
> libtool: link: gcc -I.
> -I/gnu/store/ks27x0mf95gir0cdgb9h573xbava6v1k-python-3.5.3/include/python3.5m
> -I/gnu/store/m0m6bwzi8lx7kv8zbn3hjrim6flmgnf4-openssl-1.0.2l/include
> -I/gnu/store/ldkwm8hwhknpx6651yjgc1231nh8234d-libevent-2.1.8/include
> -I/gnu/store/wdlhrg370gm42s7ggyhnvnb4xrzpls1x-expat-2.2.1/include -g -O2
> -flto -pthread -o testbound .libs/testbound.o .libs/replay.o
> .libs/fake_event.o .libs/testpkts.o .libs/worker.o .libs/acl_list.o
> .libs/daemon.o .libs/stats.o .libs/shm_main.o .libs/dns.o .libs/infra.o
> .libs/rrset.o .libs/dname.o .libs/msgencode.o .libs/as112.o
> .libs/msgparse.o .libs/msgreply.o .libs/packed_rrset.o .libs/iterator.o
> .libs/iter_delegpt.o .libs/iter_donotq.o .libs/iter_fwd.o
> .libs/iter_hints.o .libs/iter_priv.o .libs/iter_resptype.o
> .libs/iter_scrub.o .libs/iter_utils.o .libs/localzone.o .libs/mesh.o
> .libs/modstack.o .libs/view.o .libs/outbound_list.o .libs/alloc.o
> .libs/config_file.o .libs/configlexer.o .libs/configparser.o
> .libs/fptr_wlist.o .libs/locks.o .libs/log.o .libs/mini_event.o
> .libs/module.o .libs/net_help.o .libs/random.o .libs/rbtree.o
> .libs/regional.o .libs/rtt.o .libs/dnstree.o .libs/lookup3.o
> .libs/lruhash.o .libs/slabhash.o .libs/timehist.o .libs/tube.o
> .libs/winsock_event.o .libs/autotrust.o .libs/val_anchor.o
> .libs/validator.o .libs/val_kcache.o .libs/val_kentry.o .libs/val_neg.o
> .libs/val_nsec3.o .libs/val_nsec.o .libs/val_secalgo.o .libs/val_sigcrypt.o
> .libs/val_utils.o .libs/dns64.o .libs/cachedb.o .libs/authzone.o
> .libs/pythonmod.o .libs/pythonmod_utils.o .libs/respip.o .libs/ub_event.o
> .libs/keyraw.o .libs/sbuffer.o .libs/wire2str.o .libs/parse.o
> .libs/parseutil.o .libs/rrdef.o .libs/str2wire.o .libs/strlcat.o
> .libs/strlcpy.o .libs/reallocarray.o .libs/arc4random.o
> .libs/arc4random_uniform.o .libs/explicit_bzero.o .libs/arc4_lock.o
> -L/gnu/store/m0m6bwzi8lx7kv8zbn3hjrim6flmgnf4-openssl-1.0.2l/lib
> -L/gnu/store/ldkwm8hwhknpx6651yjgc1231nh8234d-libevent-2.1.8/lib
> -L/gnu/store/wdlhrg370gm42s7ggyhnvnb4xrzpls1x-expat-2.2.1/lib -lssl
> /gnu/store/ldkwm8hwhknpx6651yjgc1231nh8234d-libevent-2.1.8/lib/libevent.so
> -L/gnu/store/ks27x0mf95gir0cdgb9h573xbava6v1k-python-3.5.3/lib
> -L/gnu/store/ks27x0mf95gir0cdgb9h573xbava6v1k-python-3.5.3/lib/python3.5
> -L. -lpython3.5m -lcrypto -pthread -Wl,-rpath
> -Wl,/gnu/store/ldkwm8hwhknpx6651yjgc1231nh8234d-libevent-2.1.8/lib
> -Wl,-rpath
> -Wl,/gnu/store/ldkwm8hwhknpx6651yjgc1231nh8234d-libevent-2.1.8/lib
> -Wl,-rpath
> -Wl,/gnu/store/m0m6bwzi8lx7kv8zbn3hjrim6flmgnf4-openssl-1.0.2l/lib
> LD_PRELOAD=/tmp/nss_preload.so ./unittest
> make: *** [Makefile:308: test] Killed
> phase `check' failed after 18.3 seconds
>
> Requires further investigation.
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> java-eclipse-jetty-security@9.2.22 - log extract
>     [junit] Tests run: 22, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 0.75 sec
>     [junit] HTTP/1.1 302 Found
>     [junit] Date: Mon, 20 Nov 2017 05:32:39 GMT
>     [junit] Location: https://wobble.com/ctx/data/info
>     [junit] Content-Length: 0
>     [junit] Server: Jetty(9.2.z-SNAPSHOT)
>     [junit]
>     [junit]
>
> BUILD FAILED
> /tmp/guix-build-java-eclipse-jetty-security-9.2.22.drv-0/jetty.project-jetty-9.2.22.v20170606/jetty-security/build.xml:1:
> Test org.eclipse.jetty.security.ConstraintTest failed
>
> Total time: 3 seconds
> phase `check' failed after 4.0 seconds
>
> Requires further investigation.
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> java-eclipse-jetty-security@9.4.6 - log extract
> BUILD FAILED
> /tmp/guix-build-java-eclipse-jetty-security-9.4.6.drv-0/jetty.project-jetty-9.4.6.v20170531/jetty-security/build.xml:1:
> Test org.eclipse.jetty.security.ConstraintTest failed
>
> Total time: 12 seconds
> phase `check' failed after 13.3 seconds
>
> Requires further investigation.
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> This is how far I could get by now.
> What should we do with these?
>
> These are the latest hydra run results by the way, it might well be that
> some of these is already fixed.

We'll have to investigate them one by one, I guess.  To reduce the risk
of accidentally repeating work, I suggest that anyone who works on a
package mentioned here should reply to this thread to let everyone know
they are working on it.  When I get enough time to start working on some
of these, I'll do that.

Meanwhile, on the core-updates branch, it seems that there are other
existing problems.

I tried again to build the "covering" of icedtea (i.e., the set of
packages which, when built, are sufficient to rebuild all packages that
might be broken by changing icedtea), and I found that none of the
packages currently build against
d6adba786cf2ab1b26ff083928b64262281ff106 (which was the tip of
core-updates a few days ago).  Failures were as follows:

* kodi@18.0_alpha-6-f22d62d fails because the following fail:
    * protobuf-3.4.1
    * libvpx-1.6.1
    * icu4c-60.1

* All other 38 packages in the "covering" for icedtea fail because the
  following fails:
    * icu4c-60.1

So, on the core-updates branch at least, the appropriate first step
seems like it would be to fix icu4c.  Here's the error:

--8<---------------cut here---------------start------------->8---
   g++   ...  dayperiodrules.cpp
   g++   ...  number_decimalquantity.cpp
   g++   ...  number_decimfmtprops.cpp
number_decimalquantity.cpp: In member function ‘icu_60::number::impl::DecimalQuantity& icu_60::number::impl::DecimalQuantity::setToDouble(double)’:
number_decimalquantity.cpp:333:9: error: ‘_Generic’ is not a member of ‘std’
     if (std::signbit(n) != 0) {
         ^
In file included from /gnu/store/nz2m4gdvgzcrkqa4xwv360iskh7syj7i-gcc-5.5.0/include/c++/cmath:44:0,
                 from number_decimalquantity.cpp:9:
number_decimalquantity.cpp:333:14: error: expected primary-expression before ‘float’
     if (std::signbit(n) != 0) {
              ^
number_decimalquantity.cpp:333:14: error: expected primary-expression before ‘default’
     if (std::signbit(n) != 0) {
              ^
number_decimalquantity.cpp:333:14: error: expected primary-expression before ‘long’
     if (std::signbit(n) != 0) {
              ^
number_decimalquantity.cpp:333:14: error: expected primary-expression before ‘:’ token
     if (std::signbit(n) != 0) {
              ^
number_decimalquantity.cpp:337:9: error: ‘__builtin_isnan’ is not a member of ‘std’
     if (std::isnan(n) != 0) {
         ^
number_decimalquantity.cpp:337:9: note: suggested alternative:
<built-in>: note:   ‘__builtin_isnan’
number_decimalquantity.cpp:339:16: error: ‘__builtin_isfinite’ is not a member of ‘std’
     } else if (std::isfinite(n) == 0) {
                ^
number_decimalquantity.cpp:339:16: note: suggested alternative:
<built-in>: note:   ‘__builtin_isfinite’
--8<---------------cut here---------------end--------------->8---

I am currently doing a git bisect to try and find out what caused this
failure.  I'll let you know once I know more.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]