From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31319@debbugs.gnu.org
Subject: bug#31319: ghc-case-insensitive: Duplicate 'inputs' field.
Date: Thu, 10 May 2018 13:59:51 -0400 [thread overview]
Message-ID: <87lgcrcrxk.fsf@netris.org> (raw)
In-Reply-To: <878t8swj9n.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 10 May 2018 00:34:28 +0200")
Hi Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> Our 'ghc-case-insensitive' package contains two 'inputs' field
>> initializers. If I'm not mistaken, the first one is being effectively
>> ignored, so 'ghc-hunit' is not actually an input.
>>
>> It would be good to clean this up so that we can start raising errors
>> when duplicate field initializers are present.
>
> What about applying your patch that detects duplicate fields, rebuilding
> all the .go files, and then resolving any such case by keeping only the
> last occurrence of the field?
>
> This is what happens currently anyway so it won’t change the derivations
> produced for the faulty packages.
It's true that it wouldn't change anything to simply remove those
ignored duplicate field initializers. However, I thought it would be
better to give people familiar with these packages an opportunity to
investigate. Someone may have had a good reason for adding those
inputs, even if they are not strictly needed for a successful build.
Of course, at some point we should timeout on this. I would advocate
commenting out the redundant duplicates instead of simply deleting them,
along with a FIXME comment asking someone to investigate. We could also
look in the commit history to find out who added those redundant inputs,
and ask them directly.
If you're impatient to get the duplicate field detection patch committed
soon, I could implement these "timeout" measures in the next couple of
days.
What do you think?
Mark
next prev parent reply other threads:[~2018-05-10 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 17:49 bug#31319: ghc-case-insensitive: Duplicate 'inputs' field Mark H Weaver
2018-05-09 22:34 ` Ludovic Courtès
2018-05-10 17:59 ` Mark H Weaver [this message]
2018-05-10 20:30 ` Ludovic Courtès
2018-07-02 13:05 ` Ludovic Courtès
2018-07-19 10:02 ` Ludovic Courtès
2018-07-20 21:23 ` Mark H Weaver
2019-01-22 22:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgcrcrxk.fsf@netris.org \
--to=mhw@netris.org \
--cc=31319@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.