From: ludo@gnu.org (Ludovic Courtès)
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 33080@debbugs.gnu.org
Subject: [bug#33080] [PATCH] gnu: Add inferno.
Date: Sat, 10 Nov 2018 19:05:32 +0100 [thread overview]
Message-ID: <87lg60yfir.fsf@gnu.org> (raw)
In-Reply-To: <87bm7sjmfc.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Wed, 17 Oct 2018 23:25:11 +0200")
Hi Diego,
Sorry for the late reply.
Diego Nicola Barbato <dnbarbato@posteo.de> skribis:
> This patch adds inferno as discussed here:
> https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00031.html
In that thread we discussed the font issue, and I’m unsure if it was
resolved:
<https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00265.html>
Is everything “known good” with this version of the patch?
> From c97b28e97a210cc31e34c08bc1abdc8bd74114fa Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Wed, 17 Oct 2018 23:07:40 +0200
> Subject: [PATCH] gnu: Add inferno.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Register it.
Overall it LGTM! Minor suggestions here:
> + #:phases
> + (let* ((bash (assoc-ref %build-inputs "bash"))
> + (objtype ,@(match (%current-system)
> + ((or "armhf-linux" "aarch64-linux")
> + `("arm"))
> + (_
> + `("386"))))
> + (out (assoc-ref %outputs "out"))
> + (root (string-append out "/share/inferno"))
> + (root/bindir (string-append root "/Linux/"
> + objtype "/bin"))
> + (bindir (string-append out "/bin"))
> + (infwm-script (string-append bindir "/infwm")))
> + `(,(assoc 'set-paths %standard-phases)
> + (unpack . ,(lambda* (#:key source #:allow-other-keys)
For consistency, I would very much prefer if we could use
‘modify-phases’ here, which is what is used throughout gnu/packages.
If that’s fine with you, could you update the patch?
> + (synopsis
> + "Compact operating system for building cross-platform distributed systems")
Maybe shorten to “Operating system for building distributed systems”?
Thanks!
Ludo’.
next prev parent reply other threads:[~2018-11-10 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 21:25 [bug#33080] [PATCH] gnu: Add inferno Diego Nicola Barbato
2018-11-10 18:05 ` Ludovic Courtès [this message]
2018-11-15 11:22 ` Diego Nicola Barbato
2018-11-15 11:51 ` Ludovic Courtès
2021-07-13 12:51 ` bug#33080: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg60yfir.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33080@debbugs.gnu.org \
--cc=dnbarbato@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.