From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 37083@debbugs.gnu.org
Subject: [bug#37083] [PATCH] machine: Implement 'digital-ocean-environment-type'.
Date: Sun, 13 Oct 2019 12:56:21 +0200 [thread overview]
Message-ID: <87lftoap7u.fsf@gnu.org> (raw)
In-Reply-To: <877e5sm4kl.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 29 Sep 2019 00:36:10 +0200")
Hi Jakob,
A friendly reminder. :-)
I can commit it on your behalf if you lack the bandwidth right now.
Thanks,
Ludo’.
Ludovic Courtès <ludo@gnu.org> skribis:
> Hi Jakob!
>
> zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
>
>> gnu/machine/digital-ocean.scm: New file.
>> gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>> doc/guix.texi (Invoking 'guix deploy'): Add documentation for
> ^
> Nitpick: please add a “*” before each bullet. :-)
>
> Apart from that, LGTM, woohoo!
>
>> +(define (fetch-endpoint endpoint)
>> + "Return the contents of the Digital Ocean API endpoint ENDPOINT as an
>> +alist. This procedure is quite a bit more specialized than 'json-fetch', as it
>> +takes care to set headers such as 'Accept' and 'Authorization' appropriately."
>> + (define headers
>> + `((user-agent . "Guix Deploy")
>> + (Accept . "application/json")
>> + (Authorization . ,(format #f "Bearer ~a" (%digital-ocean-token)))))
>> + (json-fetch (string-append %api-base endpoint) #:headers headers))
>
> Note for later: we could use ‘define-json-mapping’ to work on Scheme
> records rather than on alists.
>
>> + (message (G_ "No Digital Ocean access token was provided. This \
>> +may be fixed by setting the environment variable GUIX_DIGITAL_OCAEN_TOKEN to \
> ^^
> Typo.
>
> Thank you!
>
> Ludo’.
next prev parent reply other threads:[~2019-10-13 10:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 16:41 [bug#37083] [PATCH 0/1] (Help needed!) machine: Implement 'digital-ocean-environment-type' Jakob L. Kreuze
2019-08-19 16:43 ` [bug#37083] [PATCH 1/1] " Jakob L. Kreuze
2019-08-27 10:38 ` [bug#37083] [PATCH 0/1] (Help needed!) " Ludovic Courtès
2019-09-04 12:08 ` Ludovic Courtès
2019-09-05 14:15 ` Jakob L. Kreuze
2019-09-07 20:10 ` Jakob L. Kreuze
2019-09-08 19:37 ` Ludovic Courtès
2019-09-21 20:56 ` Jakob L. Kreuze
2019-09-23 8:24 ` Ludovic Courtès
2019-09-28 20:46 ` Jakob L. Kreuze
2019-09-28 20:47 ` [bug#37083] [PATCH] " Jakob L. Kreuze
2019-09-28 22:36 ` Ludovic Courtès
2019-10-13 10:56 ` Ludovic Courtès [this message]
2019-10-22 16:34 ` Ludovic Courtès
2019-10-22 20:56 ` Jakob L. Kreuze
2019-10-23 9:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lftoap7u.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37083@debbugs.gnu.org \
--cc=zerodaysfordays@sdf.lonestar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.