From: Marius Bakke <marius@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>, 41552@debbugs.gnu.org
Subject: [bug#41552] [PATCH] gnu: Add remid-lv2.
Date: Sat, 30 May 2020 13:33:17 +0200 [thread overview]
Message-ID: <87lfl93beq.fsf@gnu.org> (raw)
In-Reply-To: <94c136949f58964383c2fabe6a28aa80bc3c79ea.camel@zrythm.org>
[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]
Alexandros Theodotou <alex@zrythm.org> writes:
> Hi,
>
> This patch adds the reMID LV2 plugin.
Thanks!
[...]
> +(define-public remid-lv2
> + (package
> + (name "remid-lv2")
> + (version "0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/ssj71/"
> + "reMID.lv2/archive/v"
> + version ".tar.gz"))
The GitHub /archive/ URLs are not stable: they might fall out of GitHubs
cache and be regenerated, with different time stamps. So we should use
git-fetch here instead.
This is different from "/releases/", which are uploaded. Unfortunately
GitHubs UI makes it difficult to tell the difference short of looking at
the URL.
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f)) ; no tests included
> + (inputs
> + `(("glib" ,glib)
> + ("alsa-lib" ,alsa-lib)
> + ("jack" ,jack-1)
> + ("lv2" ,lv2)))
Nit: we usually sort inputs. Helpful when there are dozens.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (home-page "https://github.com/ssj71/reMID.lv2")
> + (synopsis
> + "MIDI-controlled implementation of the SID 6581 chip used in the
> +Commodore 64")
> + (description
> + "The 6581 SID chip is the sound chip used in the Commodore 64 computer.
> +reMID is a MIDI implementation of the 6581 SID chip using the reSID library
> +to provide a virtual SID-based synthesizer, controllable in real-time via
> +MIDI. It includes support for scripted instruments that allow complex sonic
> +control of the chip.")
Why yes, I know some of these words :-) would it make sense to define
"SID" here with @acronym?
> + (license license:gpl2)))
This is actually GPL2+, because none of the source files say "version 2
only" (and some actually say explicitly GPL2-or-later).
Can you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-30 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 0:37 [bug#41552] [PATCH] gnu: Add remid-lv2 Alexandros Theodotou
2020-05-30 11:33 ` Marius Bakke [this message]
2020-07-08 19:43 ` Alexandros Theodotou
2020-07-21 21:06 ` bug#41552: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfl93beq.fsf@gnu.org \
--to=marius@gnu.org \
--cc=41552@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.