From: Marius Bakke <marius@gnu.org>
To: Milkey Mouse <milkeymouse@meme.institute>, 48525@debbugs.gnu.org
Subject: [bug#48525] [PATCH core-updates] gnu: rust: Add profiling support.
Date: Tue, 25 May 2021 22:35:19 +0200 [thread overview]
Message-ID: <87lf82pn5k.fsf@gnu.org> (raw)
In-Reply-To: <CBLXF76ODQ34.3FK3HIMXDW3C1@jupiter>
[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]
"Milkey Mouse" <milkeymouse@meme.institute> skriver:
> On Sun May 23, 2021 at 7:20 AM PDT, Marius Bakke wrote:
>> Instead of backporting this patch to 1.49, I think it would be better to
>> switch the default Rust to the latest version before enabling profiling
>> support.
>
> OK, I will submit a v2 of the patch. Should I do so as a reply, or
> close this thread by emailing the @debbugs.gnu.org address? I'm still a
> little new to email- and patch-based workflows.
Simply replying to this issue is great.
>> Unfortunately 1.50 currently fails to build on core-updates, so we'll
>> need a volunteer to fix that. Would you like to give it a try? :-)
>
> rust-1.50? It builds fine for me. I am on commit 42162c84dc (with this
> patch on top):
>
> $ ./pre-inst-env guix build rust@1.50
> /gnu/store/klr7jrzxl3mzprd88f857kw5mam15h78-rust-1.50.0-cargo
> /gnu/store/3x656k3s66kjb87aphly9p5v401af863-rust-1.50.0-doc
> /gnu/store/nkkfvyl52mmvx12ccwvs54c44yns4yk5-rust-1.50.0
> /gnu/store/kq4i7q55gxfl47124vfkiqzp5bi7737r-rust-1.50.0-rustfmt
>
> I suppose I should note I don't use substitutes--but that shouldn't
> make a difference, should it?
Oh you're right, it does work! Sorry for the confusion. It must have
been a transient failure on my end last I tried it. Substitutes should
not make a difference -- the end result should (ideally) be
bit-identical in either case.
I suppose we can promote Rust 1.52 to the default unless there are
big(?) compatibility problems. IIRC the upcoming librsvg requires it.
Thanks!
Marius
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2021-05-25 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 18:37 [bug#48525] [PATCH core-updates] gnu: rust: Add profiling support Milkey Mouse
2021-05-23 14:20 ` Marius Bakke
2021-05-25 1:13 ` Milkey Mouse
2021-05-25 20:35 ` Marius Bakke [this message]
2021-05-25 23:03 ` [bug#48525] [PATCH core-updates 1/2] gnu: rust: Update to 1.52 Milkey Mouse
2021-05-25 23:03 ` [bug#48525] [PATCH core-updates 2/2] gnu: rust: Add profiling support Milkey Mouse
2024-01-20 22:42 ` bug#48525: [PATCH core-updates] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf82pn5k.fsf@gnu.org \
--to=marius@gnu.org \
--cc=48525@debbugs.gnu.org \
--cc=milkeymouse@meme.institute \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.