all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: phodina <phodina@protonmail.com>
Cc: "50652@debbugs.gnu.org" <50652@debbugs.gnu.org>
Subject: [bug#50652] [PATCH] gnu: Add mjpg-streamer.
Date: Thu, 30 Sep 2021 23:19:32 +0200	[thread overview]
Message-ID: <87lf3d223f.fsf_-_@gnu.org> (raw)
In-Reply-To: <hD6LlWVBC3R-cbxAiM8cz7I0jB3Sa5ylDtw0hKTMAoO33ko3LiG8m5CLpx5p14Cq8-rBEwIleZW4MWPF60w2O8JMpA-6TC9pVy5QgtT-eCI=@protonmail.com> (phodina@protonmail.com's message of "Sat, 18 Sep 2021 10:29:39 +0000")

Hi,

phodina <phodina@protonmail.com> skribis:

> * gnu/packages/video.scm: (mjpg-streamer): New variable.

[...]

> +(define-public mjpg-streamer
> +  (let ((commit "310b29f4a94c46652b20c4b7b6e5cf24e532af39")
> +        (revision "1"))

Normally we only package releases.  If there’s a good reason to pick a
commit instead, please add a comment right above it so we know why.

> +    (package
> +      (name "mjpg-streamer")
> +      (version commit)

Please see
<https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on how
to construct version numbers for snapshots.

> +      (home-page "https://github.com/jacksonliam/mjpg-streamer")
> +      (license license:gpl2))))

Source headers such as
<https://github.com/jacksonliam/mjpg-streamer/blob/master/mjpg-streamer-experimental/plugins/input_control/dynctrl.c>
explicitly say “or any later version”, so it should be ‘license:gpl2+’.

Unfortunately
<https://github.com/jacksonliam/mjpg-streamer/tree/master/mjpg-streamer-experimental/www>
alone shows a .jar (binary file) and a bunch of “minified” (non-source)
JS files.

Our criterion is that it should be possible to build the package from
source, so we should remove at least all pre-built binary files and,
ideally, pre-built minified JS.  I invite you to give it a try and
report back, whether or not it succeeds.

Thanks,
Ludo’.




  reply	other threads:[~2021-09-30 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18  8:57 [bug#50652] [PATCH] gnu: Add mjpg-streamer phodina via Guix-patches via
2021-09-18 10:29 ` [bug#50652] [PATCH v2] " phodina via Guix-patches via
2021-09-30 21:19   ` Ludovic Courtès [this message]
2021-10-02 20:31     ` [bug#50652] [PATCH] " phodina via Guix-patches via
2021-10-04 13:48       ` bug#50652: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf3d223f.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=50652@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.