From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 53901@debbugs.gnu.org
Subject: [bug#53901] [PATCH] publish: Sign only normative narinfo fields.
Date: Wed, 09 Feb 2022 18:29:10 +0000 [thread overview]
Message-ID: <87leyjevpk.fsf@cbaines.net> (raw)
In-Reply-To: <20220209175224.26851-1-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> A consequence is that a mirror operator who’d like to, say,
> remove some of the compression methods cannot do that, unless they
> are in a position to resign narinfos.
>
> This patch fixes it by computing the signature over the normative
> fields only (plus the “Deriver” field, although it’s not strictly
> necessary). The result looks like this:
...
> Notice that URL/Compression come after the signature.
>
> I added a test to ‘tests/substitute.scm’ to be entirely sure
> that (guix narinfo) handles these correctly.
>
> Thoughts?
This sounds good to me.
Going back to talk of enabling zstd substitutes on
bordeaux.guix.gnu.org, this approach will be really helpful, as it means
it's something the nar-herder can do, without needing the signing key.
Also, at some point, it would be good to move narinfo-string out to
(guix narinfo), which would allow for the build coordinator to use it,
rather than it's own implementation.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2022-02-09 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:52 [bug#53901] [PATCH] publish: Sign only normative narinfo fields Ludovic Courtès
2022-02-09 18:29 ` Christopher Baines [this message]
2022-02-09 21:49 ` Ludovic Courtès
2022-02-10 9:00 ` pukkamustard
2022-02-10 21:09 ` Ludovic Courtès
2022-02-11 10:30 ` pukkamustard
2022-02-14 10:29 ` bug#53901: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leyjevpk.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=53901@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.