all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: phodina <phodina@protonmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	Maxime Devos <maximedevos@telenet.be>,
	Brendan Tildesley <mail@brendan.scot>,
	Leo Famulari <leo@famulari.name>,
	"marekpasnikowski@protonmail.com"
	<marekpasnikowski@protonmail.com>,
	"marius@gnu.org" <marius@gnu.org>,
	Hartmut Goebel <h.goebel@crazy-compilers.com>,
	57608@debbugs.gnu.org
Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages
Date: Sat, 24 Sep 2022 15:12:55 +0200	[thread overview]
Message-ID: <87leq8apbc.fsf_-_@gnu.org> (raw)
In-Reply-To: <ANCM3vMC9_nvIF4bkAdXPil90L78_O63O-cwGQkGIdp5uJXqDZ6Cyh3RurYRW6qqUVN1TEGURVHBNqnQrpDPLZ9Qt2Xg1SSVQQS7a8Nsioc=@protonmail.com> (phodina@protonmail.com's message of "Mon, 19 Sep 2022 17:50:24 +0000")

Hi!

An impressive patch series.  :-)

phodina <phodina@protonmail.com> skribis:

> From ce8fab8c61ade5c317445a5df26189e51061c1ec Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Wed, 7 Sep 2022 07:48:41 +0200
> Subject: [PATCH] gnu: Add fwupd service.
>
> * gnu/services/firmware.scm (fwupd): New variable.

Simply:

  * gnu/services/firmware.scm: New file.
  * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

… and actually add it to gnu/local.mk.

> +++ b/gnu/services/firmware.scm
> @@ -0,0 +1,70 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright ?? 2022 Petr Hodina <phodina@protonmail.com>

Typo.

> +(define-record-type* <fwupd-configuration> fwupd-configuration
> +                     make-fwupd-configuration fwupd-configuration?
> +                     (fwupd fwupd-configuration-fwupd
> +                            (default fwupd)))

Please indent in the same way as done elsewhere.

We’ll also need an entry in the manual for this one, maybe under
“Desktop Services”?

Ludo’.




  reply	other threads:[~2022-09-24 13:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  7:14 [bug#57608] Upstreaming KDE Plasma and rest of packages phodina via Guix-patches via
2022-09-19 17:50 ` phodina via Guix-patches via
2022-09-24 13:12   ` Ludovic Courtès [this message]
2022-09-24 13:15   ` Ludovic Courtès
2022-10-02 17:14     ` guix-patches--- via
2022-10-04  6:52       ` phodina via Guix-patches via
2022-10-04 11:07         ` guix-patches--- via
2022-10-04 14:01           ` phodina via Guix-patches via
2022-10-06 12:09             ` phodina via Guix-patches via
2022-10-06 18:29               ` kiasoc5 via Guix-patches via
2022-10-07 12:57                 ` phodina via Guix-patches via
2022-10-07 14:09                   ` Maxim Cournoyer
2022-10-10 13:03                     ` guix-patches--- via
2022-11-21 21:11               ` Marius Bakke
2022-11-22 10:20                 ` phodina via Guix-patches via
2022-11-22 10:56                   ` Marius Bakke
2022-12-27 21:15                     ` phodina via Guix-patches via
2022-12-28  0:48                       ` Maxim Cournoyer
2022-10-29 11:59 ` Brendan Tildesley
2022-10-29 20:32   ` guix-patches--- via
2022-10-29 23:49     ` Brendan Tildesley
2022-10-31  7:42     ` phodina via Guix-patches via
2023-09-02  4:23 ` bug#57608: " 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leq8apbc.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=57608@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    --cc=leo@famulari.name \
    --cc=mail@brendan.scot \
    --cc=marekpasnikowski@protonmail.com \
    --cc=marius@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=maximedevos@telenet.be \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.