From: Christopher Baines <mail@cbaines.net>
To: guix-devel@gnu.org
Subject: Notes from the live patch review discussion today at the Guix Days
Date: Fri, 03 Feb 2023 11:39:23 +0100 [thread overview]
Message-ID: <87lelff2ki.fsf@cbaines.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
These are some notes from the discuussion about patch review this
morning at the Guix Days.
Where to start:
- qa.guix.gnu.org
- debbugs.guix.gnu.org
- issues.guix.gnu.org
- debbugs.el
- email
- personal inbox
- lei (public inbox) ( https://yhetil.org/guix/ )
- IRC (someone asking for review)
Applying the patches locally:
- Pipe it from local email to git am
- lei emacs package, apply via public inbox and email id
- cherry pick commits from the branches that qa.guix.gnu.org creates
- (named issue-XXXXX)
What do people reviewing patches look at?
- What kind of patch, what is being changed?
- Testing the changes
- Look at the results of the qa.guix.gnu.org builds and linter
Once you've applied the patches:
- Email the bug/submitter
- Saving drafts as you review multiple patches can be helpful
- Do you remove guix-patches@gnu.org as a CC? Some do, some don't.
- Close via debbugs.el
- Showing the submitter what you've changed as a comitter
- Use the range diff in Git
- Copying the Git changes before fixing up/squashing
- Adding some Fixes: bit to the commit message, maybe we should do
this more?
Opportunities:
- Being able to see when the automated testing for an issue (all
issues) might finish
- ...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
reply other threads:[~2023-02-03 10:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelff2ki.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.