From: Andrew Tropin <andrew@trop.in>
To: Bruno Victal <mirai@makinata.eu>, 61982@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>, philip@philipmcgrath.com
Subject: [bug#61982] [PATCH 1/2] home: services: xdg-base-directories: Set correct value for XDG_STATE_HOME.
Date: Fri, 07 Apr 2023 10:43:50 +0400 [thread overview]
Message-ID: <87lej4w5sp.fsf@trop.in> (raw)
In-Reply-To: <3005f8a58ec5afc447f2baf40958956bd0d16099.1678029530.git.mirai@makinata.eu>
[-- Attachment #1: Type: text/plain, Size: 3058 bytes --]
On 2023-03-05 15:19, Bruno Victal wrote:
> XDG Base Directory Specification 0.8 officially introduces the
> XDG_STATE_HOME environment variable.
>
> Fixes <https://issues.guix.gnu.org/issue/61809>.
>
> * gnu/home/services/xdg.scm
> (home-xdg-base-directories-configuration)[state-home]: Set default value according to spec.
> Update field documentation.
> (home-xdg-base-directories-service-type): Update service description.
> ---
> gnu/home/services/xdg.scm | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/gnu/home/services/xdg.scm b/gnu/home/services/xdg.scm
> index 3007493f85..ac557b4c3d 100644
> --- a/gnu/home/services/xdg.scm
> +++ b/gnu/home/services/xdg.scm
> @@ -104,11 +104,11 @@ (define-configuration home-xdg-base-directories-configuration
> Specification, but helps to make implementation of home services more
> consistent.")
> (state-home
> - (path "$HOME/.local/var/lib")
> - "Base directory for programs to store state files, like databases,
> -analogus to @file{/var/lib}, but for user. It is not a part of XDG
> -Base Directory Specification, but helps to make implementation of home
> -services more consistent."))
> + (path "$HOME/.local/state")
Ironically enough, it was my first idea for default value :)
> + "Base directory for programs to store state data that should persist
> +between (application) restarts, such as logs, but are not important or
> +portable enough to the user to warrant storing them in
> +@env{XDG_DATA_HOME}."))
>
> (define (home-xdg-base-directories-environment-variables-service config)
> (map
> @@ -158,12 +158,12 @@ (define home-xdg-base-directories-service-type
> (compose identity)
> (extend last-extension-or-cfg)
> (description "Configure XDG base directories. This
> -service introduces two additional variables @env{XDG_STATE_HOME},
> -@env{XDG_LOG_HOME}. They are not a part of XDG specification, at
> -least yet, but are convenient to have, it improves the consistency
> -between different home services. The services of this service-type is
> -instantiated by default, to provide non-default value, extend the
> -service-type (using @code{simple-service} for example).")))
> +service introduces an additional @env{XDG_LOG_HOME} variable. It's not
> +a part of XDG specification, at least yet, but are convenient to have,
> +it improves the consistency between different home services. The
> +services of this service-type is instantiated by default, to provide
> +non-default value, extend the service-type (using @code{simple-service}
> +for example).")))
>
> (define (generate-home-xdg-base-directories-documentation)
> (generate-documentation
>
> base-commit: d92ec2f2812c76b23aab778e26708cf353542ae9
Applied and pushed the first patch as
5c893787be78a79433fe1343f5b70cd647e8f667
Will think about the second one a little more and reply on that later.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2023-04-07 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 15:16 [bug#61982] [PATCH 0/2] Respect XDG Base Directory Specification 0.8 Bruno Victal
2023-03-05 15:19 ` [bug#61982] [PATCH 1/2] home: services: xdg-base-directories: Set correct value for XDG_STATE_HOME Bruno Victal
2023-03-05 15:19 ` [bug#61982] [PATCH 2/2] home: services: xdg-base-directories: Deprecate XDG_LOG_HOME Bruno Victal
2023-04-07 8:45 ` Andrew Tropin
2023-04-07 11:47 ` Bruno Victal
2023-04-07 12:46 ` Andrew Tropin
2023-04-09 19:09 ` Philip McGrath
2023-04-09 19:57 ` ( via Guix-patches via
2023-04-09 20:01 ` ( via Guix-patches via
2023-06-15 9:35 ` bug#61982: " Andrew Tropin
2023-06-15 18:09 ` [bug#61982] " Philip McGrath
2023-06-16 3:28 ` Andrew Tropin
2023-06-17 18:22 ` Philip McGrath
2023-04-07 6:43 ` Andrew Tropin [this message]
2023-06-09 21:01 ` [bug#61982] [PATCH 0/2] Respect XDG Base Directory Specification 0.8 Ludovic Courtès
2023-06-14 9:27 ` Andrew Tropin
2023-04-11 20:01 ` [bug#61982] [PATCH 2/2] home: services: xdg-base-directories: Deprecate XDG_LOG_HOME ( via Guix-patches via
2023-04-12 17:17 ` Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lej4w5sp.fsf@trop.in \
--to=andrew@trop.in \
--cc=61982@debbugs.gnu.org \
--cc=mirai@makinata.eu \
--cc=philip@philipmcgrath.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.