all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Kaelyn Takata <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, 62467@debbugs.gnu.org
Subject: [bug#62467] [PATCH gnome-team v3 01/15] gnu: librsvg-2.40: Fix test failure with Pango 1.50.
Date: Tue, 11 Apr 2023 16:52:17 -0400	[thread overview]
Message-ID: <87leiykupq.fsf@gmail.com> (raw)
In-Reply-To: <0ff0469c1b12b2572b7707e1da89408b65b96de3.camel@protonmail.com> (Kaelyn Takata's message of "Mon, 3 Apr 2023 16:37:58 +0000")

Hi,

Kaelyn Takata <liliana.prikler@gmail.com> writes:

> * gnu/packages/gnome.scm (librsvg-2.40): Fix test failure with Pango 1.50.
>
> Signed-off-by: Andreas Enge <andreas@enge.fr>
> Signed-off-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
> ---
>  gnu/packages/gnome.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 49ff1464f5..6db6004356 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -73,6 +73,7 @@
>  ;;; Copyright © 2022 Rene Saavedra <nanuui@protonmail.com>
>  ;;; Copyright © 2022 Alexandros Theodotou <alex@zrythm.org>
>  ;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
> +;;; Copyright © 2023 Kaelyn Takata <kaelyn.alexi@protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3780,6 +3781,12 @@ (define-public librsvg-2.40
>                 (("gdk_pixbuf_cache_file = .*$")
>                  "gdk_pixbuf_cache_file = $(TMPDIR)/loaders.cache\n"))
>               #t))
> +         (add-before 'check 'fix-test-with-pango-1.50
> +           (lambda _
> +	     ;; Changes between pango 1.48 and 1.50 caused the text to be one
> +	     ;; pixel lower in the output image compared to the reference.
> +             (substitute* "tests/fixtures/reftests/bugs/587721-text-transform.svg"
> +	       (("660\\.9") "659.9"))))
>           (add-before 'check 'remove-failing-tests
>             (lambda _
>               (with-directory-excursion "tests/fixtures/reftests"

LGTM, although such fragil tests perhaps could be simply disabled to
spare someone the hassle to investigate them when they break again in
the future.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-04-11 20:53 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26 19:20 [bug#62467] [PATCH gnome-team 0/5] Update fundamental packages Liliana Marie Prikler
2023-03-26 15:39 ` [bug#62467] [PATCH gnome-team v2 01/12] gnu: glib: Update to 2.76.1 Liliana Marie Prikler
2023-04-08 19:37   ` Maxim Cournoyer
2023-04-08 19:54     ` Liliana Marie Prikler
2023-04-09  5:03       ` Maxim Cournoyer
2023-03-26 15:39 ` [bug#62467] [PATCH gnome-team v3 02/15] " Liliana Marie Prikler
2023-03-26 15:39 ` [bug#62467] [PATCH gnome-team 1/5] " Liliana Marie Prikler
2023-03-26 15:53 ` [bug#62467] [PATCH gnome-team v2 02/12] gnu: Make pango-next the new pango Liliana Marie Prikler
2023-04-08 19:39   ` Maxim Cournoyer
2023-03-26 15:53 ` [bug#62467] [PATCH gnome-team v3 03/15] " Liliana Marie Prikler
2023-03-26 15:53 ` [bug#62467] [PATCH gnome-team 2/5] " Liliana Marie Prikler
2023-03-26 18:53 ` [bug#62467] [PATCH gnome-team v3 04/15] gnu: pango: Update to 1.50.14 Liliana Marie Prikler
2023-03-26 18:53 ` [bug#62467] [PATCH gnome-team 3/5] " Liliana Marie Prikler
2023-03-26 18:53 ` [bug#62467] [PATCH gnome-team v2 03/12] " Liliana Marie Prikler
2023-04-08 19:39   ` Maxim Cournoyer
2023-03-26 19:14 ` [bug#62467] [PATCH gnome-team v2 04/12] gnu: Make gobject-introspection-next the new gobject-introspection Liliana Marie Prikler
2023-04-08 19:41   ` Maxim Cournoyer
2023-03-26 19:14 ` [bug#62467] [PATCH gnome-team 4/5] " Liliana Marie Prikler
2023-03-26 19:14 ` [bug#62467] [PATCH gnome-team v3 05/15] " Liliana Marie Prikler
2023-03-26 19:19 ` [bug#62467] [PATCH gnome-team v3 06/15] gnu: gobject-introspection: Update to 1.76.1 Liliana Marie Prikler
2023-03-26 19:19 ` [bug#62467] [PATCH gnome-team v2 05/12] " Liliana Marie Prikler
2023-04-08 19:40   ` Maxim Cournoyer
2023-03-26 19:19 ` [bug#62467] [PATCH gnome-team 5/5] " Liliana Marie Prikler
2023-03-28  4:26 ` [bug#62467] [PATCH gnome-team v3 07/15] gnu: libsoup-minimal@2: Update to 2.74.3 Liliana Marie Prikler
2023-03-28  4:26 ` [bug#62467] [PATCH gnome-team v2 06/12] " Liliana Marie Prikler
2023-04-08 19:42   ` Maxim Cournoyer
2023-04-08 19:56     ` Liliana Marie Prikler
2023-04-09  5:04       ` Maxim Cournoyer
2023-03-28 16:50 ` [bug#62467] [PATCH gnome-team v2 07/12] gnu: python-pygobject: Set upstream-name Liliana Marie Prikler
2023-04-08 19:42   ` Maxim Cournoyer
2023-03-28 16:50 ` [bug#62467] [PATCH gnome-team v3 08/15] " Liliana Marie Prikler
2023-03-28 16:51 ` [bug#62467] [PATCH gnome-team v3 09/15] gnu: python-pygobject: Update to 3.44.1 Liliana Marie Prikler
2023-03-28 16:51 ` [bug#62467] [PATCH gnome-team v2 08/12] " Liliana Marie Prikler
2023-04-08 19:43   ` Maxim Cournoyer
2023-03-28 19:34 ` [bug#62467] [PATCH gnome-team v3 12/15] gnu: librsvg: Fix build Liliana Marie Prikler
2023-03-28 19:34 ` [bug#62467] [PATCH gnome-team v2 11/12] " Liliana Marie Prikler
2023-04-08 19:49   ` Maxim Cournoyer
2023-04-08 20:03     ` Liliana Marie Prikler
2023-04-09  5:07       ` Maxim Cournoyer
2023-04-10 12:51     ` Liliana Marie Prikler
2023-04-11  1:49       ` Maxim Cournoyer
2023-03-30  4:28 ` [bug#62467] [PATCH gnome-team v3 11/15] gnu: gtk+: Update to 3.24.37 Liliana Marie Prikler
2023-03-30  4:28 ` [bug#62467] [PATCH gnome-team v2 10/12] " Liliana Marie Prikler
2023-04-08 19:34   ` Maxim Cournoyer
2023-03-30 18:41 ` [bug#62467] [PATCH gnome-team v2 09/12] gnu: gtk+-2: Fix build by hardening list store Liliana Marie Prikler
2023-04-08 19:47   ` Maxim Cournoyer
2023-04-08 20:00     ` Liliana Marie Prikler
2023-04-09  5:06       ` Maxim Cournoyer
2023-03-30 18:41 ` [bug#62467] [PATCH gnome-team v3 10/15] " Liliana Marie Prikler
2023-03-31 18:54 ` [bug#62467] [PATCH gnome-team v3 13/15] gnu: inkscape: Update stable version to 1.2.1 Liliana Marie Prikler
2023-03-31 18:54 ` [bug#62467] [PATCH gnome-team v2 12/12] " Liliana Marie Prikler
2023-04-08 19:51   ` Maxim Cournoyer
2023-03-31 21:43 ` [bug#62467] [PATCH gnome-team v2 00/12] Update fundamental packages Liliana Marie Prikler
2023-04-02 17:27   ` Raghav Gururajan via Guix-patches via
2023-04-02 18:20     ` Liliana Marie Prikler
2023-04-03 16:37 ` [bug#62467] [PATCH gnome-team v3 01/15] gnu: librsvg-2.40: Fix test failure with Pango 1.50 Kaelyn Takata
2023-04-11 20:52   ` Maxim Cournoyer [this message]
2023-04-10  7:08 ` [bug#62467] [PATCH gnome-team v3 14/15] gnu: inkscape: Use new package style Liliana Marie Prikler
2023-04-10 16:12 ` [bug#62467] [PATCH gnome-team v3 15/15] gnu: Remove lib2geom 1.1 Liliana Marie Prikler
2023-04-11 20:57   ` Maxim Cournoyer
2023-04-12  5:33     ` Liliana Marie Prikler
2023-04-13  2:33       ` Maxim Cournoyer
2023-04-13  5:12         ` bug#62467: " Liliana Marie Prikler
2023-04-11  7:06 ` [bug#62467] [PATCH gnome-team v3 00/15] Update glib to 2.76.1 Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leiykupq.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=62467@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.