From: Csepp <raingloom@riseup.net>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: guix-devel@gnu.org
Subject: Re: modifying (rather than fully replacing) a build phases
Date: Thu, 29 Jun 2023 02:30:56 +0200 [thread overview]
Message-ID: <87leg3t10k.fsf@riseup.net> (raw)
In-Reply-To: <875y788kne.fsf@protonmail.com>
John Kehayias <john.kehayias@protonmail.com> writes:
> My question remains, but I've updated the patch in question to use
> #:make-flags (thanks to mirai for the idea), separating out these
> parameters from the build command and making this a much easier
> change.
>
> Still, we have examples of just copying some phase by hand to make
> adjustments, is there anything better we can/should do?
>
> On Tue, Jun 27, 2023 at 12:29 PM, John Kehayias wrote:
>
>> Hi Guixers,
>>
>> A question that is either relatively simple or else getting into the
>> weeds a bit, that I came across in my proposed patch
>> <https://issues.guix.gnu.org/64213> The general question is: how can I
>> modify a build phase without replacing it completely? More
>> specifically (as seen in the proposed patch) there is a build phase
>> consisting of just an "apply invoke" call where I want to remove one
>> of the arguments given. Is there a simple way to do this rather than
>> just manually copying and deleting that string?
>>
>> I would assume so, but I wasn't sure how to do it and couldn't quite
>> grep any examples. Some light exploring in the guix repl shows me that
>> package-arguments is a keyword list (not sure the proper terminology
>> in Guile) with #:phases a big gexp. Essentially I want to modify that
>> to remove a string. I suppose it is a question of manipulating a gexp
>> directly. (I'm sure macros can do all this but there doesn't seem to
>> be a need for that at this level, right?)
>>
>> Thanks in advance!
>> John
I think I've used assoc-ref to find the build phase I wanted and then
called it from something else. It's not super pretty, but it works.
next prev parent reply other threads:[~2023-06-29 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 1:01 modifying (rather than fully replacing) a build phases John Kehayias
2023-06-29 0:30 ` Csepp [this message]
2023-06-29 15:02 ` John Kehayias
-- strict thread matches above, loose matches on Subject: below --
2023-06-27 16:38 John Kehayias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leg3t10k.fsf@riseup.net \
--to=raingloom@riseup.net \
--cc=guix-devel@gnu.org \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.