all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 49437-done@debbugs.gnu.org
Subject: bug#49437: [PATCH core-updates] build-system/qt: Fix build failures when
Date: Sat, 20 Jan 2024 16:11:25 -0500	[thread overview]
Message-ID: <87le8jd81u.fsf_-_@gmail.com> (raw)
In-Reply-To: <52c57042714d524c092002e64dfd53e4ebde5b02.camel@telenet.be> (Maxime Devos's message of "Thu, 08 Jul 2021 19:51:25 +0200")

Hi,

Maxime Devos <maximedevos@telenet.be> writes:

> Mathieu Othacehe schreef op do 08-07-2021 om 16:45 [+0200]:
>> Hey Maxime,
>> 
>> > I am unable to test this at the moment (too little substitutes
>> > for core-updates, too little processing power locally ...), but
>> > I intent to do so later.
>> 
>> I think you are missing the attached patch here.
>
> Now attached!
>
> Greetings,
> Maxime.
>
> From b9e46156e1f35303b56fbe2ed4694385b6104214 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Tue, 6 Jul 2021 10:57:49 +0200
> Subject: [PATCH core-updates] build-system/qt: Fix build failures when
>  cross-compiling.
>
> One of the features of 'qt-build-system' is that it automatically
> creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> so.  If "bin/bash" doesn't exist among the 'inputs', then
> 'search-input-file' (used by 'wrap-all-programs') will raise an
> exception.  Address this exception by adding "bash-minimal" to
> 'host-inputs' when cross-compiling.
>
> This change does not impact native compilation; the derivations
> for natively-compiled packages remain identical.
>
> * guix/build-system/qt.scm
>   (bash-for-wrappers): New procedure.
>   (lower): Add 'bash-minimal' to 'host-inputs' when cross-compiling.

I don't think our Qt packages can be already cross-built; hence there's
no current value in adding this before addressing cross-compilation of
the qt-build-system in the first place.

Also, 'guix lint' would still complain, so for now I'm opting to close
this without applying it.

-- 
Thanks,
Maxim




      parent reply	other threads:[~2024-01-20 21:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 11:25 [bug#49437] [PATCH core-updates] build-system/qt: Fix build failures when Maxime Devos
2021-07-08 14:45 ` Mathieu Othacehe
2021-07-08 17:51   ` Maxime Devos
2021-07-08 19:37     ` Mathieu Othacehe
2021-07-08 20:59       ` Maxime Devos
2021-09-23  3:53         ` Maxim Cournoyer
2021-10-03  8:56           ` Maxime Devos
2023-03-29  2:15             ` Maxim Cournoyer
2023-04-04 18:59               ` Maxime Devos
2023-04-07 21:15                 ` Maxim Cournoyer
2024-01-20 21:11     ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le8jd81u.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=49437-done@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.