all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Attila Lendvai <attila.lendvai@gmail.com>
Cc: Attila Lendvai <attila@lendvai.name>, 68468@debbugs.gnu.org
Subject: [bug#68468] [PATCH] gnu: services: Add respawn-limit and respawn-delay.
Date: Wed, 24 Jan 2024 23:15:23 +0100	[thread overview]
Message-ID: <87le8es7ic.fsf@gnu.org> (raw)
In-Reply-To: <288643093baa2855c7b5f8cf1d9f6da2b378f965.1705315426.git.attila@lendvai.name> (Attila Lendvai's message of "Mon, 15 Jan 2024 11:43:47 +0100")

Hi,

Attila Lendvai <attila.lendvai@gmail.com> skribis:

> * gnu/services/shepherd.scm (<shepherd-service>): Add respawn-limit and
> respawn-delay.
>
> Change-Id: I54408e8fb4bcc0956d9610771bf5c566fdc2914c

Neat!  Please also mention the changes in ‘shepherd-service-file’.

> +  (respawn-limit shepherd-service-respawn-limit
> +                 (default #f))
> +  (respawn-delay shepherd-service-respawn-delay
> +                 (default #f))

Could you document them in ‘doc/guix.texi’?

> +                       #$@(if (shepherd-service-respawn-limit service)
> +                              `(#:respawn-limit
> +                                ,(shepherd-service-respawn-limit service))
> +                              '())
> +                       #$@(if (shepherd-service-respawn-delay service)
> +                              `(#:respawn-delay
> +                                ,(shepherd-service-respawn-delay service))
> +                              '())

In theory, we could end up loading code that uses #:respawn-limit in a
running shepherd that does not support it (too old).  To properly
address that, we’d need to check what shepherd version we’re talking to.

But… I think we can ignore this issue, as long as we don’t use it in
gnu/services/*.scm until some time has passed.

Thanks!

Ludo’.




  reply	other threads:[~2024-01-24 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 10:43 [bug#68468] [PATCH] gnu: services: Add respawn-limit and respawn-delay Attila Lendvai
2024-01-24 22:15 ` Ludovic Courtès [this message]
2024-01-25 15:05 ` [bug#68468] [PATCH v2] " attila.lendvai
2024-01-28 21:28   ` bug#68468: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le8es7ic.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=68468@debbugs.gnu.org \
    --cc=attila.lendvai@gmail.com \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.