From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 27943@debbugs.gnu.org
Subject: bug#27943: tar complains about too-long names (guix release)
Date: Fri, 01 Dec 2017 17:50:01 +0100 [thread overview]
Message-ID: <87k1y6e6km.fsf@gnu.org> (raw)
In-Reply-To: <20171130231220.GA908@jasmine.lan> (Leo Famulari's message of "Thu, 30 Nov 2017 18:12:20 -0500")
Leo Famulari <leo@famulari.name> skribis:
>> On Thu, Nov 30, 2017 at 02:55:52PM +0100, Ludovic Courtès wrote:
>> > I thought about it, but since it’s an unsual case, what about adding a
>> > special property to packages instead? You’d write:
>> >
>> > (package
>> > ;; …
>> > (properties '((fixed-vulnerabilities "CVE-123-4567" "CVE-123-4568"))))
>> >
>> > ‘guix lint’ would honor this property, and that would address both cases
>> > like this and situations where a CVE is known to no longer apply, as is
>> > the case with unversioned CVEs¹.
>> >
>> > Thoughts?
>
> I'd rather the property's name more clearly reflect that it doesn't
> actually fix the vulnerability, but just prevents the linter from
> complaining about it.
>
> Someone who sees this property used in a package could reasonably assume
> that it's required to list all fixed CVEs in a 'fixed-vulnerabilities'
> list, and that it is the "single source of truth" for which bugs apply
> to a package. But, it would not actually have anything to do with that,
> just being a way to silence the linter.
Yes, I see it as a last resort, and thus rarely used. When used, it
should be accompanied by a comment clearly explaining what we’re doing.
I think people are unlikely to see it as a “single source of truth”
because it’ll be used in a handful of packages only, and because
comments there should make it clear that it’s really just to placate the
linter.
> However, I can't think of a good idea for another name...
Maybe ‘lint-hidden-vulnerabilities’ or ‘hidden-vulnerabilities’, or
‘ignored-vulnerabilities’, or…? What’s you preference? :-)
> On Thu, Nov 30, 2017 at 11:49:01PM +0200, Efraim Flashner wrote:
>> I like that idea. It also allows us to mitigate a CVE without needing to
>> specifically add a patch. I've attached my first attempt at implementing
>> it.
>
> I think of `guix lint -c cve` as one of many tools for discovering
> important problems in our packages, but I don't think that we must
> absolutely silence the linter. It's always going to be imprecise, with
> both false negative and positive results.
I agree. Like patch file names, I view this new property as a way to
silence the reader when we have reliable info to do that.
Would you be OK with a more appropriate name and the understanding that
it’s there to address rare cases like this one?
Thanks for your feedback!
Ludo’.
next prev parent reply other threads:[~2017-12-01 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 7:22 bug#27943: tar complains about too-long names (guix release) Danny Milosavljevic
2017-11-28 14:26 ` Ludovic Courtès
2017-11-30 13:05 ` Efraim Flashner
2017-11-30 13:55 ` Ludovic Courtès
2017-11-30 21:49 ` Efraim Flashner
2017-11-30 23:12 ` Leo Famulari
2017-12-01 16:50 ` Ludovic Courtès [this message]
2017-12-01 18:20 ` Leo Famulari
2017-12-02 9:55 ` Ludovic Courtès
2017-12-02 9:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1y6e6km.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27943@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.