all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 30328@debbugs.gnu.org
Subject: [bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu.
Date: Tue, 06 Feb 2018 16:26:36 +0100	[thread overview]
Message-ID: <87k1vq5ec3.fsf@gnu.org> (raw)
In-Reply-To: <20180202214457.14147-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 3 Feb 2018 00:44:57 +0300")

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-browse-at-remote-gnu): New public variable.
> * gnu/packages/patches/emacs-browse-at-remote-gnu-add-support-for-gnu-repositories.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add this.

[...]

> +(define-public emacs-browse-at-remote-gnu
> +  (package
> +    (inherit emacs-browse-at-remote)
> +    (name "emacs-browse-at-remote-gnu")
> +    (source
> +     (origin
> +       (inherit (package-source emacs-browse-at-remote))
> +       (patches (search-patches "emacs-browse-at-remote-gnu\
> +-add-support-for-gnu-repositories.patch"))))))

What about simply adding the patch to ‘emacs-browse-at-remote’ if it’s
committed upstream way?

Also please make the .patch file name a bit shorter; see ‘guix lint’.

OK with these changes, thanks!

Ludo’.

  reply	other threads:[~2018-02-06 15:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 21:44 [bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu Oleg Pykhalov
2018-02-06 15:26 ` Ludovic Courtès [this message]
2018-02-06 16:47   ` Oleg Pykhalov
2018-02-07  9:18     ` Ludovic Courtès
2018-02-07 16:37       ` Oleg Pykhalov
2018-02-07 21:41         ` Ludovic Courtès
2018-02-09 19:26           ` Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1vq5ec3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30328@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.