From: ludo@gnu.org (Ludovic Courtès)
To: Roel Janssen <roel@gnu.org>
Cc: 31346@debbugs.gnu.org
Subject: [bug#31346] [PATCH] gnu: gnuzilla: Add mozjs-52.
Date: Sat, 05 May 2018 22:26:12 +0200 [thread overview]
Message-ID: <87k1shrgrf.fsf@gnu.org> (raw)
In-Reply-To: <87fu39oiwb.fsf@gnu.org> (Roel Janssen's message of "Wed, 02 May 2018 23:19:16 +0200")
Hello Roel,
Roel Janssen <roel@gnu.org> skribis:
>>From ce8b4e85b03ed76fb671a4d554f966b7eac00b8d Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Wed, 2 May 2018 22:11:34 +0200
> Subject: [PATCH] gnu: gnuzilla: Add mozjs-52.
>
> * gnu/packages/gnuzilla.scm (mozjs-52): New variable.
[...]
> +(define-public mozjs-52
> + (package
> + (inherit mozjs)
> + (name "mozjs")
You can omit ‘name’.
Also, would it be simpler to inherit from ‘mozjs-38’?
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://queue.taskcluster.net/v1/task/"
> + "YqG2fjJJSTGzGX090FjDYg/runs/0/artifacts/"
> + "public/build/mozjs-" version ".tar.bz2"))
Could we use ftp.mozilla.org instead?
> + (arguments
> + `(#:tests? #f ; Needs Mercurial or Git repository to be avalable.
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (chdir "js/src")
> + (setenv "SHELL" (which "sh"))
> + (setenv "CONFIG_SHELL" (which "sh"))
> + (setenv "AUTOCONF" (string-append
> + (assoc-ref inputs "autoconf")
> + "/bin/autoreconf"))
> + (zero? (system* "./configure"
> + (string-append "--prefix=" out)
> + "--enable-ctypes"
> + "--enable-optimize"
> + "--enable-pie"
> + "--enable-readline"
> + "--enable-shared-js"
> + "--enable-system-ffi"
> + "--with-system-icu"
> + "--with-system-nspr"
> + "--with-system-zlib"
> +
> + ;; Intl API requires bundled ICU.
> + "--without-intl-api"))))))))
This seems to be (almost) the same as for ‘mozjs-38’. Perhaps with
‘inherit’ we don’t need to duplicate all this?
Could you look into this?
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-05-05 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 21:19 [bug#31346] [PATCH] gnu: gnuzilla: Add mozjs-52 Roel Janssen
2018-05-05 20:26 ` Ludovic Courtès [this message]
2018-05-06 20:21 ` Roel Janssen
2018-05-07 8:13 ` Ludovic Courtès
2018-05-25 9:06 ` Roel Janssen
2018-08-29 20:57 ` bug#31346: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1shrgrf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31346@debbugs.gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.