all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 39694-done@debbugs.gnu.org
Subject: bug#39694: [SHEPHERD] [PATCH] build: Adjust clean targets.
Date: Fri, 06 Mar 2020 12:10:52 +0100	[thread overview]
Message-ID: <87k13xoi0z.fsf@gnu.org> (raw)
In-Reply-To: <20200220154221.22104-1-efraim@flashner.co.il> (Efraim Flashner's message of "Thu, 20 Feb 2020 17:42:21 +0200")

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> skribis:

> Makefile.am: Add man pages to the 'make clean' target.
> ---
> Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
> halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
> to the 'make clean' list and are deleted. The manpage creation works as
> expected.

[...]

> +CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)

This would remove man pages upon “make clean”, whereas they should only
be removed upon “make distclean”, per GNU conventions.

I went with a different fix in Shepherd commit
f32a2ff8ad329f224b2f693ad7e9fefac142a459.

Thank you!

Ludo’.

      reply	other threads:[~2020-03-06 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 15:42 [bug#39694] [SHEPHERD] [PATCH] build: Adjust clean targets Efraim Flashner
2020-03-06 11:10 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k13xoi0z.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=39694-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.