From: Ricardo Wurmus <rekado@elephly.net>
To: R Veera Kumar <vkor@vkten.in>
Cc: 40281@debbugs.gnu.org
Subject: [bug#40281] [PATCH v2] gnu: Add mtpaint.
Date: Fri, 03 Apr 2020 06:15:57 +0200 [thread overview]
Message-ID: <87k12xw6f6.fsf@elephly.net> (raw)
In-Reply-To: <20200331093956.GA8435@tulip>
R Veera Kumar <vkor@vkten.in> writes:
> * gnu/packages/image.scm (mtpaint): New variable.
Thank you for the patch!
> +
> +(define-public mtpaint
> + (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
> + (revision "1"))
Why is this particular commit needed? Can’t we use the latest release?
> + (package
> + (name "mtpaint")
> + (version (git-version "3.49.25" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/wjaguar/mtPaint/")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("gettext" ,gettext-minimal)
> + ("pkg-config" ,pkg-config)
> + ("pkg-config" ,pkg-config)
You have this line twice.
> + ("which" ,which)))
> + (inputs
> + `(("imlib2" ,imlib2)
> + ("libtiff" ,libtiff)
> + ("libpng" ,libpng)
> + ("libungif", libungif)
> + ("libjpeg", libjpeg)
> + ("libwebp" ,libwebp)
> + ("openjpeg" ,openjpeg)
> + ("lcms" ,lcms)
> + ("zlib", zlib)
> + ("glib" ,glib)
> + ("gtk+" ,gtk+-2)))
Could you please build with gtk+ (i.e. version 3). You probably need to
add “gtk3” to the configure flags.
> + (arguments
> + `(#:configure-flags
> + (list
> + "intl") ;; internationalized support
Please remove the line break.
For margin comments (at the end of a line) use just one semicolon please.
> + ;; no check target
> + #:tests? #f))
> + (home-page "http://mtpaint.sourceforge.net/")
> + (synopsis "Create pixel art and manipulate digital images")
> + (description
> + "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
> +It can create and edit indexed pallete or 24bit RGB images, offers
> basic
“pallete” –> “palette”
> +painting and palette manipulation tools.
Same here.
--
Ricardo
next prev parent reply other threads:[~2020-04-03 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 17:21 [bug#40281] [PATCH] gnu: Add mtpaint R Veera Kumar
2020-03-31 9:39 ` [bug#40281] [PATCH v2] " R Veera Kumar
2020-04-03 4:15 ` Ricardo Wurmus [this message]
2020-04-03 4:42 ` R Veera Kumar
2020-04-03 16:33 ` [bug#40281] [PATCH v3] " R Veera Kumar
2020-04-04 17:33 ` [bug#40281] [PATCH v4] " R Veera Kumar
2020-04-05 17:48 ` bug#40281: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k12xw6f6.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=40281@debbugs.gnu.org \
--cc=vkor@vkten.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.