From: gfleury <gfleury@disroot.org>
To: 43643@debbugs.gnu.org
Subject: bug#43643: start shepherd when a previous instance was killed by kill -9
Date: Sun, 27 Sep 2020 10:00:03 +0200 [thread overview]
Message-ID: <87k0wfejjw.fsf@disroot.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
Hi,
when killing shepherd i.e `pkill -9 shepherd` it left behind
`default-socket-file` and when restarted whithout remove the socket like
---------------------------------------------------------
rm /var/run/user/1000/shepherd/socket
---------------------------------------------------------
it throws a error:
---------------------------------------------------------
3 (primitive-load "/home/gfleury/prod/shepherd/./shepherd")
In shepherd.scm:
56:14 2 (main . _)
49:6 1 (open-server-socket _)
In unknown file:
0 (bind #<input-output: socket 16> #(1 "/run/user/1000?") #)
ERROR: In procedure bind:
In procedure bind: Address already in use
---------------------------------------------------------
something like this patch can fix it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ensure-that-default-socket-file-is-not-present.patch --]
[-- Type: text/x-diff, Size: 928 bytes --]
From 7d16c47bad6fd98cf0838d2fcd62735d846e7bab Mon Sep 17 00:00:00 2001
From: gfleury <gfleury@disroot.org>
Date: Sun, 27 Sep 2020 09:29:37 +0200
Subject: [PATCH] ensure that `default-socket-file` is not present.
* modules/shepherd.scm(main): remove a possible `default-socket-file`
left by a previous instance.
---
modules/shepherd.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/modules/shepherd.scm b/modules/shepherd.scm
index 9f80f62..d18567e 100644
--- a/modules/shepherd.scm
+++ b/modules/shepherd.scm
@@ -147,7 +147,10 @@ already ~a threads running, disabling 'signalfd' support")
(initialize-cli)
(let ((config-file #f)
- (socket-file default-socket-file)
+ (socket-file
+ (begin
+ (false-if-exception (delete-file default-socket-file))
+ default-socket-file))
(pid-file #f)
(secure #t)
(logfile #f))
--
2.28.0
next reply other threads:[~2020-09-27 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 8:00 gfleury [this message]
2020-09-27 14:19 ` bug#43643: start shepherd when a previous instance was killed by kill -9 Danny Milosavljevic
2020-09-27 18:09 ` gfleury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0wfejjw.fsf@disroot.org \
--to=gfleury@disroot.org \
--cc=43643@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.