From: "Ludovic Courtès" <ludo@gnu.org>
To: "Léo Le Bouter" <lle-bout@zaclys.net>
Cc: 46885@debbugs.gnu.org
Subject: [bug#46885] [PATCH] gnu: artanis: Update to 0.5.
Date: Wed, 17 Mar 2021 22:31:05 +0100 [thread overview]
Message-ID: <87k0q5xyau.fsf@gnu.org> (raw)
In-Reply-To: <20210303011502.15822-1-lle-bout@zaclys.net> ("Léo Le Bouter"'s message of "Wed, 3 Mar 2021 02:15:02 +0100")
Hi,
Léo Le Bouter <lle-bout@zaclys.net> skribis:
> * gnu/packages/guile-xyz.scm (artanis): Update to 0.5.
> [inputs]: Remove guile-2.2; add guile-3.0-latest and nspr.
> [propagated-inputs]: Remove guile-json-1, guile2.2-readline, and guile2.2-redis; add guile-json-3, guile-readline, and guile-redis.
[...]
> (inputs
> - `(("guile" ,guile-2.2)
> - ("nss" ,nss)))
> + `(("guile" ,guile-3.0-latest)
Just ‘guile-3.0’ (unless there’s a good reason to use
‘guile-3.0-latest’?).
Otherwise LGTM!
> (let* ((out (assoc-ref %outputs "out"))
> - (scm (string-append out "/share/guile/site/2.2"))
> - (go (string-append out "/lib/guile/2.2/site-ccache")))
> + (scm (string-append out "/share/guile/site/3.0"))
> + (go (string-append out "/lib/guile/3.0/site-ccache")))
> ;; Don't use (%site-dir) for site paths.
> (list (string-append "MOD_PATH=" scm)
> (string-append "MOD_COMPILED_PATH=" go)))
> @@ -193,7 +194,7 @@
> (("\\(%site-dir\\)")
> (string-append "\""
> (assoc-ref outputs "out")
> - "/share/guile/site/2.2\"")))))
> + "/share/guile/site/3.0\"")))))
[...]
> - (scm (string-append out "/share/guile/site/2.2"))
> - (go (string-append out "/lib/guile/2.2/site-ccache")))
> + (scm (string-append out "/share/guile/site/3.0"))
> + (go (string-append out "/lib/guile/3.0/site-ccache")))
Perhaps for a separate patch, but it would be best to avoid hardcoding
the Guile effective version number.
The other packages show how to accomplish this. Ideally, Makefile.am &
co. would refer to $(GUILE_EFFECTIVE_VERSION). When that’s not the case
(yet), we can patch them to do so, as is done for several packages in
guile-xyz.scm.
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-03-17 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:15 [bug#46885] [PATCH] gnu: artanis: Update to 0.5 Léo Le Bouter via Guix-patches via
2021-03-17 21:31 ` Ludovic Courtès [this message]
2021-08-24 20:33 ` [bug#46885] [PATCH v2 0/2] Update artanis " Arun Isaac
2021-08-30 10:08 ` Ludovic Courtès
2021-09-01 12:01 ` bug#46885: " Arun Isaac
2021-08-24 20:33 ` [bug#46885] [PATCH v2 1/2] gnu: artanis: Remove hard-coded guile effective version Arun Isaac
2021-08-24 20:33 ` [bug#46885] [PATCH v2 2/2] gnu: artanis: Update to 0.5 Arun Isaac
2021-09-01 12:38 ` [bug#46885] Thanks! jgart via Guix-patches via
2021-09-02 5:52 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0q5xyau.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=46885@debbugs.gnu.org \
--cc=lle-bout@zaclys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.