all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Ekaitz Zarraga <ekaitz@elenq.tech>, Erik Eduardo <eduarskate8@gmail.com>
Cc: 68742-done@debbugs.gnu.org, 68742@debbugs.gnu.org
Subject: [bug#68742] QA review for 68742
Date: Wed, 14 Feb 2024 13:33:11 +0000	[thread overview]
Message-ID: <87jzn7891c.fsf@cbaines.net> (raw)
In-Reply-To: <18af450b-4585-c935-487f-7d3c59b80822@elenq.tech>

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]


Ekaitz Zarraga <ekaitz@elenq.tech> writes:

> user guix
> usertag 68742 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> It's a simple addition. I think it's ok.
> I linted, and I also built, and things the author expected work.
>
> Items marked as checked: Lint warnings, Package builds, Commit messages

Thanks both, I've tweaked the indentation a little and pushed this to
master as 8d4c3032416c69f883d074f4f6d7bcc9741be75c.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2024-02-14 13:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 17:09 [bug#68742] [PATCH] gnu: river: add river.desktop on wayland-sessions Erik Eduardo
2024-01-29 16:41 ` Ekaitz Zarraga
2024-01-31  8:32 ` [bug#68742] [PATCH] gnu: river: Add river.desktop file Erik Eduardo
2024-02-08 17:32 ` [bug#68742] [PATCH v3] " Erik Eduardo
2024-02-08 19:08   ` Ekaitz Zarraga
2024-02-09 14:13   ` Ekaitz Zarraga
2024-02-14 12:19 ` [bug#68742] [PATCH v4] " Erik Eduardo
2024-02-14 12:31 ` [bug#68742] QA review for 68742 Ekaitz Zarraga
2024-02-14 13:33   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzn7891c.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=68742-done@debbugs.gnu.org \
    --cc=68742@debbugs.gnu.org \
    --cc=eduarskate8@gmail.com \
    --cc=ekaitz@elenq.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.