From: Kei Kebreau <kei@openmailbox.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27421-done@debbugs.gnu.org
Subject: bug#27421: [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase.
Date: Tue, 20 Jun 2017 19:51:19 -0400 [thread overview]
Message-ID: <87injqp6a0.fsf@openmailbox.org> (raw)
In-Reply-To: <871sqepife.fsf@fastmail.com> (Marius Bakke's message of "Tue, 20 Jun 2017 21:28:53 +0200")
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> * gnu/packages/games.scm (openttd-engine): Rename package to openttd.
>>>> [arguments]: Add it.
>>>> [native-inputs]: Add openttd-opengfx.
>>>
>>> This should also mention that the (openttd) variable is now gone.
>>> However, I would prefer keeping "openttd-engine" and only add these
>>> changes to the inherited "openttd" package. What do you think?
>>
>> That would be a more logical progression given the comment about adding
>> openttd-opengfx. I've attached the change you're talking about.
>
> LGTM, thanks!
All five patches pushed to master. Thanks for the review, Marius!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-06-21 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 17:37 [bug#27421] OpenTTD OpenGFX patches Kei Kebreau
2017-06-18 17:44 ` [bug#27421] [PATCH 1/5] gnu: Add nml Kei Kebreau
2017-06-18 18:01 ` Marius Bakke
2017-06-18 19:01 ` Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 2/5] gnu: Add dos2unix Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 3/5] gnu: Add grfcodec Kei Kebreau
2017-06-18 18:04 ` Marius Bakke
2017-06-18 17:45 ` [bug#27421] [PATCH 4/5] gnu: Add openttd-opengfx Kei Kebreau
2017-06-18 18:24 ` Marius Bakke
2017-06-18 18:51 ` Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase Kei Kebreau
2017-06-18 18:33 ` Marius Bakke
2017-06-18 21:03 ` Kei Kebreau
2017-06-20 19:28 ` Marius Bakke
2017-06-20 23:51 ` Kei Kebreau [this message]
2017-06-18 18:02 ` [bug#27421] [PATCH 2/5] gnu: Add dos2unix Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87injqp6a0.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=27421-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.