From: "Ludovic Courtès" <ludo@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 35785@debbugs.gnu.org, Einar Largenius <einar.largenius@gmail.com>
Subject: bug#35785: ‘string->uri’ is locale-dependent and breaks in ‘sv_SE’
Date: Tue, 04 Jun 2019 09:42:55 +0200 [thread overview]
Message-ID: <87imtlhk3k.fsf@gnu.org> (raw)
In-Reply-To: <87ef4asq53.fsf@ngyro.com> (Timothy Sample's message of "Mon, 03 Jun 2019 10:24:40 -0400")
Hello,
Timothy Sample <samplet@ngyro.com> skribis:
>>> From 7b02be4c050c7b17a0e2685e8e453295f798c360 Mon Sep 17 00:00:00 2001
>>> From: Timothy Sample <samplet@ngyro.com>
>>> Date: Sun, 2 Jun 2019 14:41:20 -0400
>>> Subject: [PATCH] Make URI handling locale independent.
>>>
>>> Fixes <https://bugs.gnu.org/35785>.
>>>
>>> * module/web/uri.scm (digits, hex-digits, letters): New variables.
>>> (ipv4-regexp, ipv6-regexp, domain-label-regexp, top-label-regexp,
>>> userinfo-pat, host-pat, ipv6-host-pat, port-pat, scheme-pat): Explicitly
>>> list each character instead of using character ranges.
>>> * test-suite/tests/web-uri.test: Add corresponding tests.
>>
>> [...]
>>
>>> + (pass-if "http://www.example.com (sv_SE)"
>>> + (dynamic-wind
>>> + (lambda () #t)
>>> + (lambda ()
>>> + (with-locale "sv_SE.utf8"
>>> + (reload-module (resolve-module '(web uri)))
>>> + (uri=? (string->uri "http://www.example.com")
>>> + #:scheme 'http #:host "www.example.com" #:path "")))
>>
>> Aren’t ‘reload-module’ calls a leftover that can now be removed (also in
>> the other test)?
>
> I needed to reload the modules like that to make the tests fail without
> the patch and pass with it. My understanding is that the bug happens
> at regex compile time, which happens when the module is loaded. If I
> don’t reload the module, the old URI code passes the tests, since the
> regexes were compiled with a locale that does not trigger the bug. It’s
> a little wacky, sure, but it was the best idea I could come up with.
Oooh, I see. Could you add a comment to explain this? Then we’re done.
>> For the sv_SE test, what about taking a host name with a ‘w’, since
>> that’s the use case that allowed us to uncover this bug?
>
> I thought I was being clever by using a “www” hostname, but apparently
> it’s so normalized as to be invisible! Feel free to change it to
> something more obvious like “w.com” or whatever.
Silly me, I guess I need new glasses. :-)
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-06-04 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 20:03 bug#35785: guix won't download if locale is set to swedish Einar Largenius
2019-05-18 11:55 ` Ludovic Courtès
2019-05-19 17:45 ` Einar Largenius
2019-05-20 8:20 ` Ludovic Courtès
2019-05-20 9:14 ` bug#35785: ‘string->uri’ is locale-dependent and breaks in ‘sv_SE’ Ludovic Courtès
2019-05-27 11:05 ` Ricardo Wurmus
2019-05-27 13:39 ` Timothy Sample
2019-05-28 11:17 ` Ludovic Courtès
2019-06-03 0:39 ` Timothy Sample
2019-06-03 13:01 ` Ludovic Courtès
2019-06-03 14:24 ` Timothy Sample
2019-06-04 7:42 ` Ludovic Courtès [this message]
2019-06-04 13:56 ` Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imtlhk3k.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35785@debbugs.gnu.org \
--cc=einar.largenius@gmail.com \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.