From: Benjamin Slade <slade@jnanam.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 36064@debbugs.gnu.org
Subject: [bug#36064] [PATCH] sawfish.scm - update sawfish to 1.12
Date: Mon, 10 Jun 2019 00:36:09 -0600 [thread overview]
Message-ID: <87imtevteu.fsf@jnanam.net> (raw)
In-Reply-To: <cu7lfyha4jw.fsf@systemreboot.net>
On 2019-06-04T07:00:35-0600, Arun Isaac <arunisaac@systemreboot.net> wrote:
> Thanks for contributing to Guix!
Hi Arun,
Thanks for the feedback.
> Please split this into three separate patches -- one each for librep,
> rep-gtk and sawfish. For the commit messages, please use the
> conventional Guix update commit message. If you use Emacs, this can
> be done easily using the update yasnippet in etc/snippets of the Guix
> source tree.
I'll do so.
> > - (home-page "http://sawfish.wikia.com/wiki/Librep")
> > + (home-page "https://sawfish.wikia.com/wiki/Librep")
> Shouldn't https://sawfish.tuxfamily.org/ be the home-page for all
> three packages? Why are we listing the wiki as the home-page?
I just followed the previous version, updating to 'https'. But
https://sawfish.tuxfamily.org/ doesn't actually have information
directly about Librep, while the wiki page the previous commit linked to
does provide information about the package.
> > (define-public rep-gtk
> > (package
> > (name "rep-gtk")
> > - (version "0.90.8.2")
> > + (version "0.90.8.2") ; next point release hasn't been distributed; requires autoconf etc.
> We don't usually package beta releases. So, there is no need to
> mention this as a comment. But, the current release is
> 0.90.8.3. Please update to that.
0.90.8.3 isn't packaged for distribution though, so it may be
beta-ish. In any case, I don't know how to get it to build, given that
it's not packaged for distribution at this point.
> > (define-public sawfish
> > (package
> > (name "sawfish")
> > - (version "1.11")
> > + (version "1.12.0") ; point release 1.12.90 hasn't been distributed; requires autoconf etc.
> We don't usually package beta releases. So, there is no need to
> mention this as a comment.
> > - (home-page "http://sawfish.wikia.com/wiki/Main_Page")
> > + (home-page "https://sawfish.wikia.com/wiki/Main_Page")
> See above for comment on home-page.
Effectively, then, I'm just updating `sawfish` itself, given the lack of
a need for the comments I had made about versions, so I'll resubmit a
patch just updating the sawfish package.
--
Dr Benjamin Slade - https://babbagefiles.xyz
`(pgp_fp: ,(21BA 2AE1 28F6 DF36 110A 0E9C A320 BBE8 2B52 EE19))
'(sent by mu4e on Emacs running under GNU/Linux . https://gnu.org )
next prev parent reply other threads:[~2019-06-10 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 23:35 [bug#36064] [PATCH] sawfish.scm - update sawfish to 1.12 Benjamin Slade
2019-06-04 13:00 ` Arun Isaac
2019-06-10 6:36 ` Benjamin Slade [this message]
2019-06-27 6:58 ` bug#36064: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imtevteu.fsf@jnanam.net \
--to=slade@jnanam.net \
--cc=36064@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.