all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35790@debbugs.gnu.org
Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type.
Date: Sun, 16 Jun 2019 14:00:16 +0100	[thread overview]
Message-ID: <87imt5u1lr.fsf@cbaines.net> (raw)
In-Reply-To: <87ftolj0v2.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Rather than emiting warnings directly to a port, have the checkers return the
>> warning or warnings.
>>
>> This makes it easier to use the warnings in different ways, for example,
>> loading the data in to a database, as you can work with the <lint-warning>
>> records directly, rather than having to parse the output to determine the
>> package and location.
>
> I like it!
>
> Maybe we should just ignore the i18n issue for now and keep
> already-translated messages in <lint-warning>.

I want the Guix Data Service to support internationalisation at some
point, so I've had a go at doing this. I'll say more in reply to your
other email.

> One question I have: before, warnings would be emitted as we go; now, we
> first collect all the warnings for a given package, and emit all of them
> at once.  How does it look in terms of UX?

Not quite, warnings are emitted once returned from each checker for each
package. The display will only be delayed if a checker takes a long time
to return the warnings, which I don't think happens (or at least happens
much).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2019-06-16 13:01 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18  9:32 [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type Christopher Baines
2019-05-21 14:41 ` Ludovic Courtès
2019-06-01 18:31   ` Christopher Baines
2019-06-07  7:44     ` Ludovic Courtès
2019-06-16 13:00       ` Christopher Baines [this message]
2019-06-20 11:40         ` Ludovic Courtès
2019-06-01 19:09   ` Christopher Baines
2019-06-07  7:38     ` Ludovic Courtès
2019-06-16 12:56       ` [bug#35790] [PATCH] scripts: lint: Separate the message warning text and data Christopher Baines
2019-06-24  8:36         ` Ludovic Courtès
2019-06-29  8:46           ` Christopher Baines
2019-06-16 13:05       ` [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type Christopher Baines
2019-06-20 11:49         ` Ludovic Courtès
2019-06-24  6:46           ` Christopher Baines
2019-06-24  8:33             ` Ludovic Courtès
2019-06-24  8:39             ` Ludovic Courtès
2019-06-29 11:25               ` [bug#35790] [PATCH 1/2] " Christopher Baines
2019-06-29 11:25                 ` [bug#35790] [PATCH 2/2] scripts: lint: Separate the message warning text and data Christopher Baines
2019-06-29 11:56               ` [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type Christopher Baines
2019-07-01 12:32                 ` Ludovic Courtès
2019-07-02 19:25                   ` [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module Christopher Baines
2019-07-02 19:25                     ` [bug#35790] [PATCH 2/2] lint: Separate checkers by dependence on the internet Christopher Baines
2019-07-12 14:38                       ` Ludovic Courtès
2019-07-14 18:17                         ` Christopher Baines
2019-07-12 14:36                     ` [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module Ludovic Courtès
2019-07-14 18:03                       ` Christopher Baines
2019-07-14 18:23                         ` Christopher Baines
2019-07-15  9:20                         ` Ludovic Courtès
2019-07-15 19:45                           ` [bug#35790] [PATCH 1/4] scripts: lint: Handle warnings with a record type Christopher Baines
2019-07-15 19:45                             ` [bug#35790] [PATCH 2/4] scripts: lint: Separate the message warning text and data Christopher Baines
2019-07-15 19:45                             ` [bug#35790] [PATCH 3/4] lint: Move the linting code to a different module Christopher Baines
2019-07-15 19:45                             ` [bug#35790] [PATCH 4/4] lint: Separate checkers by dependence on the internet Christopher Baines
2019-07-15 20:17                               ` Ludovic Courtès
2019-07-15 22:23                                 ` bug#35790: " Christopher Baines
2019-07-16 21:34                                   ` [bug#35790] " Ludovic Courtès
2019-07-15 19:51                           ` [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module Christopher Baines
2019-07-02 20:15                   ` [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imt5u1lr.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=35790@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.