From: "Ludovic Courtès" <ludo@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40482-done@debbugs.gnu.org
Subject: bug#40482: Test failure in tests/packages.scm after merging master into core-updates
Date: Sat, 11 Apr 2020 00:36:00 +0200 [thread overview]
Message-ID: <87imi7ufxr.fsf@gnu.org> (raw)
In-Reply-To: <87ftdfo7lf.fsf@devup.no> (Marius Bakke's message of "Tue, 07 Apr 2020 13:31:24 +0200")
Hello,
Marius Bakke <mbakke@fastmail.com> skribis:
> On the current "core-updates" branch (commit
> a533c5a1835cbeafaf595c4474e2ce6adde7de8d), one test starts to fail if
> commits 190ddfe21e3d87719733d12fb9b5eb176125a49f and
> a187cc562890895ad41dfad00eb1d5c4a4b00936 are applied:
>
> test-name: package-transitive-supported-systems, implicit inputs
> location: tests/packages.scm:362
> source:
> + (test-equal
> + "package-transitive-supported-systems, implicit inputs"
> + %supported-systems
> + (let ((p (dummy-package
> + "foo"
> + (build-system gnu-build-system)
> + (supported-systems
> + `("does-not-exist" "foobar" ,@%supported-systems)))))
> + (parameterize
> + ((%current-system "armhf-linux"))
> + (package-transitive-supported-systems p))))
> expected-value: ("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux" "mips64el-linux" "i586-gnu")
> actual-value: ("x86_64-linux" "i686-linux")
> result: FAIL
>
>
> After some trial and error I found that simply removing the test added
> by commit a187cc562890895ad41dfad00eb1d5c4a4b00936 will make the above
> test pass!
This is fixed by e85d4cecbe253e59a8a2a42b6ce427d96ff10534.
This has to do with memoization of things that are actually
system-dependent. This is why you’d see this side effect: in one case,
the first thing memoized would be the armhf graph, in the other case it
would be the x86_64 one.
Concretely,
guix build coreutils -s x86_64-linux -s armhf-linux
would return the right derivation for x86_64 and a bogus one for armhf
(one that depends on Mes, Gash, etc.).
Thanks,
Ludo’.
prev parent reply other threads:[~2020-04-10 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 11:31 bug#40482: Test failure in tests/packages.scm after merging master into core-updates Marius Bakke
2020-04-10 22:36 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imi7ufxr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40482-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.