From: "Ludovic Courtès" <ludo@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40510-done@debbugs.gnu.org
Subject: bug#40510: [PATCH] gnu: Add wolf-shaper.
Date: Thu, 23 Apr 2020 23:59:01 +0200 [thread overview]
Message-ID: <87imhplv8a.fsf@gnu.org> (raw)
In-Reply-To: <8bac4beb758b4ab138718cd0f9211da1b69e6d63.camel@zrythm.org> (Alexandros Theodotou's message of "Wed, 08 Apr 2020 17:31:46 +0100")
Hi Alexandros,
Alexandros Theodotou <alex@zrythm.org> skribis:
> From ff5050712a95e5dc84325ecceac50f84cd71ee14 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Wed, 8 Apr 2020 17:30:45 +0100
> Subject: [PATCH 2/2] gnu: Add wolf-spectrum.
>
> * gnu/packages/music.scm (wolf-spectrum): New variable.
[...]
> + (synopsis "2D spectrogram plugin")
> + (description "Wolf Spectrum is a real-time 2D spectrogram plugin.
> +It is provided as an LV2 plugin and as a standalone Jack application.")
> + (home-page "https://pdesaulniers.github.io/wolf-shaper/")
> + (license license:gpl3)))
[...]
> From 80dbd4b8eea3beea8eb312acdb56374f486bb9b7 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Wed, 8 Apr 2020 17:21:19 +0100
> Subject: [PATCH 1/2] gnu: Add wolf-shaper.
>
> * gnu/packages/music.scm (wolf-shaper): New variable.
[...]
> + (synopsis "Waveshaper plugin")
> + (description "Wolf Shaper is a waveshaper plugin with a graph editor.
> +It is provided as an LV2 plugin and as a standalone Jack application.")
> + (home-page "https://pdesaulniers.github.io/wolf-shaper/")
> + (license license:gpl3)))
Applied!
Two comments though:
1. I believe the license is really ‘gpl3+’ because I don’t see
anything saying “version 3 only”. However, the situation is a bit
confused because source files apparently still contain the ISC
license header, perhaps an omission since the projects were
apparently recently relicensed.
2. The synopses could be improved: plugin for what? What application
domain? The descriptions could also be expounded a bit, and this
would make ‘guix search’ happier. :-)
Could you follow up on these two things?
Thanks,
Ludo’.
prev parent reply other threads:[~2020-04-23 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 16:31 [bug#40510] [PATCH] gnu: Add wolf-shaper Alexandros Theodotou
2020-04-08 16:37 ` Alexandros Theodotou
2020-04-23 21:59 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imhplv8a.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40510-done@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.