From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Soo <jsoo1@asu.edu>
Cc: 43930@debbugs.gnu.org
Subject: [bug#43930] gnu: Add emacs-graphql-mode.
Date: Tue, 13 Oct 2020 09:15:36 +0200 [thread overview]
Message-ID: <87imbe61gn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87imbgofzz.fsf@asu.edu> (John Soo's message of "Sun, 11 Oct 2020 09:59:44 -0700")
Hello,
John Soo <jsoo1@asu.edu> writes:
> I've been writing some graphql recently and graphql-mode has been
> invaluable.
Thank you. Some comments follow.
> +(define-public emacs-graphql-mode
> + (let ((commit "9bed568ec86242dbe30bdbab324aa0eb2cd9bf08")
Could you add a comment explaining why you don't use a tagged commit
(in this case, there is none)?
> + (revision "1"))
> + (package
> + (name "emacs-graphql-mode")
> + (version commit)
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/davazp/graphql-mode")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4"))))
Nitpick: please move the string on the same line as `base32'.
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/davazp/graphql-mode")
Nitpick: please move the string on the same line as `home-page'.
> + (synopsis "Emacs mode to edit GraphQL schema and queries")
> + (description
> + "This package provides an Emacs mode for editing graphql queries and
> +schemas.")
I suggest to expound the description a bit. For example, using
commentary section of the library, it could be something along the lines
of:
This package implements a major mode to edit GraphQL schemas and
query. The basic functionality includes syntax highlight and
indentation. Additionally, it is able to send GraphQL queries to an
end-point URL.
Files with the @file{.graphql} and @file{.gql} extensions are
automatically opened with this mode.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-13 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 16:59 [bug#43930] gnu: Add emacs-graphql-mode John Soo
2020-10-13 7:15 ` Nicolas Goaziou [this message]
2020-10-19 17:44 ` John Soo
2020-10-19 20:45 ` bug#43930: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbe61gn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43930@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.