From: Vinicius Monego <monego@posteo.net>
To: Marius Bakke <marius@gnu.org>
Cc: 43883@debbugs.gnu.org
Subject: [bug#43883] [PATCH] gnu: Add libebur128.
Date: Thu, 15 Oct 2020 20:56:44 -0300 [thread overview]
Message-ID: <87imbb11s3.fsf@posteo.net> (raw)
In-Reply-To: <87imbdrfo7.fsf@gnu.org>
Marius Bakke writes:
> Vinicius Monego <monego@posteo.net> writes:
>
>> * gnu/packages/audio.scm (libebur128): New variable.
>
> [...]
>
>> + (arguments
>> + `(;; Tests require .wav files that are not distributed with the code.
>> + ;; See https://github.com/jiixyj/libebur128/issues/82.
>> + #:tests? #f
>
> It is easy to provide these data files using an (origin ...) in
> native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check
> the terms of use first, as the data set is unrelated to this package.
>
> (I don't really have a strong opinion here, just sayin')
>
I had a look at the terms (link provided in the issue referenced above)
and commercial usage is forbidden, making the audio files nonfree. Also, the
zip file weighs 87 MB.
>> + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>
> Note: you can use #:build-type "Release" instead. The default is
> "RelWithDebInfo", so it's customary to add a comment when changing it.
> Is there a particular reason to not provide debugging information here?
Oh, I wasn't aware of #:build-type. Thanks.
I remove debugging information to save space. The ideal case is to move
it to a separate output as in
https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html
, but that is something I have yet to take a look at.
I will enable it again in the v2 and add a comment about the data.
next prev parent reply other threads:[~2020-10-15 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:12 [bug#43883] [PATCH] gnu: Add libebur128 Vinicius Monego
2020-10-13 21:15 ` Marius Bakke
2020-10-15 23:56 ` Vinicius Monego [this message]
2020-10-18 21:59 ` bug#43883: " Marius Bakke
2020-10-16 14:21 ` [bug#43883] [PATCH v2] " Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbb11s3.fsf@posteo.net \
--to=monego@posteo.net \
--cc=43883@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.