From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 路辉 <luhux76@gmail.com>, 53319@debbugs.gnu.org
Subject: [bug#53319] [PATCH] gnu: Add n2n.
Date: Tue, 22 Feb 2022 19:49:34 +0100 [thread overview]
Message-ID: <87ilt63fep.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <c691ad56a7cd5c32b53487ba661d2d9881a589f6.camel@telenet.be> (Maxime Devos's message of "Tue, 22 Feb 2022 12:36:24 +0100")
Hello,
Maxime Devos <maximedevos@telenet.be> writes:
> 'configure' is run during build, so for cross-compilation, a sh from
> 'native-inputs' shoud be used instead of 'inputs':
>
> (("/bin/sh") (search-input-file (or native-inputs inputs) "/bin/sh"))
True, I keep forgetting about this. It would be more natural to use
(search-input-file native-inputs "/bin/sh"), but, IIRC, native-inputs
may be empty if we are not cross-compiling.
I will fix it.
> or simpler:
>
> (("/bin/sh") (which "sh"))
IIUC, search-input-file is a replacement for `which', so that seems to
be going backwards.
Of course, if `which' is the preferred solution for package style, I'd
love to hear a confirmation about it.
> Also, this package definition packages version 2.8. Why not package
> the latest version instead?
The OP waited one month without any feedback. I consider this is more
respectful to apply the patch in its current version rather than
requesting more changes now. YMMV.
Of course, the update can happen in a later, very welcome, patch.
> Also, looking at
> <https://github.com/ntop/n2n/blob/472a9878f72299466ddbce2a232ea9e081159fa9/configure.seed#L94>,
> it seems that n2n might not be bit-for-bit reproducible.
I agree this package has room for improvement. Hopefully, 路辉 can have
a look at it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-02-22 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 14:47 [bug#53319] [PATCH] gnu: Add n2n 路辉
2022-01-28 10:10 ` Nicolas Goaziou
2022-02-22 11:36 ` Maxime Devos
2022-02-22 18:49 ` Nicolas Goaziou [this message]
2022-03-20 12:20 ` 路辉
2022-02-22 11:20 ` bug#53319: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilt63fep.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53319@debbugs.gnu.org \
--cc=luhux76@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.