From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54201-done@debbugs.gnu.org
Subject: bug#54201: [PATCH] Add wego
Date: Sat, 19 Mar 2022 00:59:09 +0100 [thread overview]
Message-ID: <87ilsau81e.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87ee2zqs4b.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 18 Mar 2022 14:59:00 +0100")
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.
Done.
>> + (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.
Done.
>> + (license isc)))
>
> Perhaps #:prefix license: ?
I thought we needed to use the prefix only when there was a conflict in
the module.
Anyhow, done.
> Otherwise LGTM, thanks!
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2022-03-19 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 0:29 [bug#54201] [PATCH] Add wego Nicolas Goaziou
2022-03-18 13:59 ` Ludovic Courtès
2022-03-18 23:59 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilsau81e.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=54201-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.