From: Ricardo Wurmus <rekado@elephly.net>
To: Olivier Dion <olivier.dion@polymtl.ca>
Cc: gwl-devel@gnu.org
Subject: Re: [PATCH v2 1/2] packages: Support for full Guix specification
Date: Tue, 26 Apr 2022 20:11:39 +0200 [thread overview]
Message-ID: <87ilqv66yd.fsf@elephly.net> (raw)
In-Reply-To: <20220422184359.7929-2-olivier.dion@polymtl.ca>
Hi Olivier,
thank for the patch!
> -(define (lookup-package specification)
> +(define (%lookup-package name+version output)
> + (list (match (apply lookup-inferior-packages
> + (cons (current-guix) (string-split name+version #\@)))
I don’t think we need the cons here. As long as the last argument to
APPLY is a list everything’s fine.
> + ((first . rest) first)
> + (_ (raise (condition
> + (&gwl-package-error
> + (package-spec (string-append name+version output)))))))
> + output))
I’d prefer to have this return multiple values instead of a compound
value. And if it had to be a compound value for some reason I’d prefer
to use a dedicated data type (a record value) instead of a list.
> +
> +(define* (lookup-package specification #:optional (output "out"))
> (log-event 'guix (G_ "Looking up package `~a'~%") specification)
> - (match (lookup-inferior-packages (current-guix) specification)
> - ((first . rest) first)
> - (_ (raise (condition
> - (&gwl-package-error
> - (package-spec specification)))))))
> + (match (string-split specification #\:)
> + ((name+version sub-drv) (%lookup-package name+version sub-drv))
> + ((name+version) (simple-package (%lookup-package name+version output)))))
I’m not sure about forcing SIMPLE-PACKAGE to be used because the return
value might be an output. The stuff in (guix inferior) also doesn’t
know about outputs, so I feel that we shouldn’t attempt to include
syntax for selecting outputs. IIRC we’ll end up with all outputs in the
environment, so there’s no actual effect of picking a specific output.
I’d prefer to revisit this once (guix inferior) supports selecting
outputs. What do you think?
> (define (valid-package? val)
> - (or (package? val)
> - (inferior-package? val)))
> + (or
> + (and (list? val)
> + (valid-package? (car val))
> + (string? (cadr val)))
> + (package? val)
> + (inferior-package? val)))
> +
> +(define (simple-package pkg)
> + (if (list? pkg) (car pkg) pkg))
Generally, I prefer to use MATCH instead of CAR and CDR. But in this
case I’d prefer not to overload the meaning of “package” to include
lists.
--
Ricardo
next prev parent reply other threads:[~2022-04-26 19:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 17:22 Packages specification does not work Olivier Dion via
2022-04-21 18:25 ` Olivier Dion via
2022-04-21 19:51 ` [PATCH v1 1/2] packages: Support for full Guix specification Olivier Dion
2022-04-21 19:51 ` [PATCH v1 2/2] pre-inst-env.in: Export GUIX_EXTENSIONS_PATH Olivier Dion
2022-04-29 11:42 ` Ricardo Wurmus
2022-04-21 20:10 ` [PATCH v1 1/2] packages: Support for full Guix specification Olivier Dion via
2022-04-22 18:43 ` [PATCH v2 0/2] Support full package specifications Olivier Dion
2022-04-22 18:43 ` [PATCH v2 1/2] packages: Support for full Guix specification Olivier Dion
2022-04-26 18:11 ` Ricardo Wurmus [this message]
2022-04-26 18:59 ` Olivier Dion via
2022-04-26 20:30 ` Ricardo Wurmus
2022-04-26 21:52 ` Olivier Dion via
2022-04-22 18:43 ` [PATCH v2 2/2] pre-inst-env.in: Export GUIX_EXTENSIONS_PATH Olivier Dion
2022-04-29 9:00 ` zimoun
2022-04-29 18:02 ` [PATCH v3 0/1] Support full package specifications Olivier Dion
2022-04-29 18:02 ` [PATCH v3 1/1] packages: Support for full Guix specification Olivier Dion
2022-05-22 6:43 ` Ricardo Wurmus
2022-05-22 12:33 ` Olivier Dion via
2022-05-17 20:40 ` [PATCH v3 0/1] Support full package specifications Olivier Dion via
2022-05-22 12:38 ` [PATCH v4] packages: Support for full Guix specification Olivier Dion
2022-05-23 21:02 ` Ricardo Wurmus
2022-05-23 21:45 ` [PATCH v5] " Olivier Dion
2022-06-01 13:07 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilqv66yd.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=gwl-devel@gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.