From: "Ludovic Courtès" <ludo@gnu.org>
To: zamfofex <zamfofex@twdb.moe>
Cc: 54933-done@debbugs.gnu.org
Subject: bug#54933: [patch] Add Liquid War 6
Date: Fri, 29 Apr 2022 23:14:22 +0200 [thread overview]
Message-ID: <87ilqr618x.fsf@gnu.org> (raw)
In-Reply-To: <1383010778.267330.1649930429294@privateemail.com> (zamfofex@twdb.moe's message of "Thu, 14 Apr 2022 07:00:29 -0300 (BRT)")
Hi,
zamfofex <zamfofex@twdb.moe> skribis:
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index de398c297f..8765f70761 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
Applied with mostly cosmetic changes:
> + (inputs
> + (list guile-2.0 zlib expat sqlite ncurses readline curl doxygen python-2
> + libxslt perl graphviz glu libcaca
> + (sdl-union (list sdl sdl-image sdl-ttf sdl-mixer))))
I passed it through ‘guix style’ and moved ‘doxygen’ to ‘native-inputs’
as suggested by ‘guix lint’.
> + (arguments
> + '(#:configure-flags
> + (list
> + "--enable-allinone"
> + "CFLAGS=-Wno-error"
> + (string-append "CPPFLAGS="
> + "-I" (search-input-directory %build-inputs "include/SDL")))))
I used a gexp and ‘this-package-input’here.
> + (description
> + (string-append
> + "Liquid War 6 is a unique multiplayer wargame. Your army is a blob of "
> + "liquid and you have to try and eat your opponents. Rules are very "
> + "simple yet original, they have been invented by Thomas Colcombet."))
I changed that to a literal string:
https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
For future patches please take a look at:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
In particular, please use ‘git format-patch’ and possibly ‘git
send-email’ to send patches. That ensures the commit log and authorship
are preserved and makes the reviewer’s life easier. :-)
Thanks!
Ludo’.
prev parent reply other threads:[~2022-04-29 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:00 [bug#54933] [patch] Add Liquid War 6 zamfofex
2022-04-29 21:14 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilqr618x.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54933-done@debbugs.gnu.org \
--cc=zamfofex@twdb.moe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.