From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches@gnu.org>
Cc: 60212-done@debbugs.gnu.org, jgart <jgart@dismail.de>
Subject: bug#60212: [PATCH] gnu: Add emacs-fzf.
Date: Tue, 20 Dec 2022 11:25:58 +0100 [thread overview]
Message-ID: <87ili6cqx5.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221220032916.5047-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Mon, 19 Dec 2022 21:29:16 -0600")
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable.
Thank you.
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'patch-fzf-executable
> + (lambda* (#:key inputs #:allow-other-keys)
> + (make-file-writable "fzf.el")
Nitpick: The expression above is usually not necessary, even though some
package definitions use it.
> + (emacs-substitute-variables "fzf.el"
> + ("fzf/executable" (search-input-file inputs "/bin/fzf"))))))))
> + (inputs (list fzf))
> + (home-page "https://github.com/bling/fzf.el")
> + (synopsis "Front-end for fzf")
I expounded it a bit.
> + (description "An @command{emacs} front-end for @command{fzf}.")
Please write full sentences in descriptions, even if upstream does not.
Also, "@command{emacs}" conveys no more information than "Emacs". So
does "@command{fzf}" vs "Fzf". The simpler the better, IMO.
Applied!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-12-20 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 3:29 [bug#60212] [PATCH] gnu: Add emacs-fzf jgart via Guix-patches via
2022-12-20 10:25 ` Nicolas Goaziou [this message]
2022-12-21 0:54 ` jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ili6cqx5.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=60212-done@debbugs.gnu.org \
--cc=guix-patches@gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.