From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Bruno Victal <mirai@makinata.eu>
Cc: 62490@debbugs.gnu.org, ludo@gnu.org, mail@cbaines.net
Subject: [bug#62490] [PATCH] services: nginx: Make logging level configurable.
Date: Tue, 28 Mar 2023 11:03:45 -0400 [thread overview]
Message-ID: <87ilekor3i.fsf@gmail.com> (raw)
In-Reply-To: <156c2153-cca0-2f59-6ca8-edad4fb7e919@makinata.eu> (Bruno Victal's message of "Tue, 28 Mar 2023 15:32:56 +0100")
OK,
Bruno Victal <mirai@makinata.eu> writes:
> Hi Maxim,
>
> On 2023-03-28 15:12, Maxim Cournoyer wrote:
>> Bruno Victal <mirai@makinata.eu> writes:
>>>
>>> +(define-compile-time-procedure (assert-valid-log-level (level symbol?))
>>> + "Ensure @var{level} is one of @code{'debug}, @code{'info}, @code{'notice},
>>> +@code{'warn}, @code{'error}, @code{'crit}, @code{'alert}, or @code{'emerg}."
>>> + (unless (memq level '(debug info notice warn error crit alert emerg))
>>> + (raise
>>> + (make-compound-condition
>>> + (formatted-message (G_ "unknown log level '~a'") level)
>>> + (condition (&error-location
>>> + (location
>>> + (source-properties->location procedure-call-location)))))))
>>> + level)
>>
>> It's the first time I've seen define-compile-time-procedure in actual
>> use. Is it really necessary? What happens if you omit wrapping
>> assert-valid-log-level with it?
>
> It will still work, provided the declaration is adjusted accordingly.
> As for the reasons and benefits of using define-compile-time-procedure,
> it's best explained at <https://logs.guix.gnu.org/guix/2023-03-20.log#131047>.
I guess it's not actually useful here, since none of the fields thunked?
As another note, the nginx-configuration record looks simple enough that
perhaps it'd best be migrated to use the define-configuration method,
which could be made as a prior commit to this change.
As a benefit it'd validate the other field types as well.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-28 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:51 [bug#62490] [PATCH] services: nginx: Make logging level configurable Bruno Victal
2023-03-28 14:12 ` Maxim Cournoyer
2023-03-28 14:32 ` Bruno Victal
2023-03-28 15:03 ` Maxim Cournoyer [this message]
2023-04-02 15:39 ` Ludovic Courtès
2023-04-11 17:12 ` bug#62490: " Maxim Cournoyer
2023-04-03 11:58 ` [bug#62490] [PATCH v2 1/2] " Bruno Victal
2023-04-03 11:58 ` [bug#62490] [PATCH v2 2/2] services: nginx: Add reopen action Bruno Victal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilekor3i.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=62490@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.