From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: file-system-shepherd-service: Use mount-file-system.
Date: Sun, 04 Dec 2016 22:12:00 +0100 [thread overview]
Message-ID: <87h96j5rhb.fsf@gnu.org> (raw)
In-Reply-To: <20161202113256.GA30350@jocasta.intra> (John Darrington's message of "Fri, 2 Dec 2016 12:32:56 +0100")
John Darrington <john@darrington.wattle.id.au> skribis:
> On Wed, Nov 30, 2016 at 01:51:23PM +0100, Ludovic Court??s wrote:
> John Darrington <jmd@gnu.org> skribis:
>
> > * gnu/services/base.scm (file-system-shepherd-service): Use mount-file-system
> > instead of manually mounting the file system.
>
> [...]
>
> > + #$(if create?
> > + #~(mkdir-p #$target)
> > + #~#t)
>
> #~#t is equivalent to #t.
>
> > + (mount-file-system
> > + `(#$device #$title #$target #$type #$flags #$options
> > + #$check?) #:root "/")
> > #t))
>
> #t must be align with the parent of ???(mount-file-system???.
>
> If you confirmed that at least ???make check-system TESTS=basic??? passes,
> fine with me.
>
>
> Perhaps somebody who already has a copy of qemu in their store could check that
> for me?
hydra.gnu.org has a copy. :-)
Anyway, thanks for pushing this!
Ludo’.
prev parent reply other threads:[~2016-12-04 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:33 [PATCH] gnu: file-system-shepherd-service: Use mount-file-system John Darrington
2016-11-30 12:51 ` Ludovic Courtès
2016-12-02 11:32 ` John Darrington
2016-12-02 16:44 ` David Craven
2016-12-04 21:12 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h96j5rhb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.