From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 28198@debbugs.gnu.org
Subject: [bug#28198] [PATCH 4/4] tests: databases: Add MongoDB test.
Date: Thu, 31 Aug 2017 14:37:45 +0200 [thread overview]
Message-ID: <87h8wnud46.fsf@gnu.org> (raw)
In-Reply-To: <20170823092516.6846-4-mail@cbaines.net> (Christopher Baines's message of "Wed, 23 Aug 2017 10:25:16 +0100")
Christopher Baines <mail@cbaines.net> skribis:
> * gnu/tests/databases.scm (%test-mongodb): New variable.
FWIW I’d suggest squashing it with the patch that adds the MongoDB
service, since they really go together.
> +(define %mongodb-os
> + (operating-system
> + (inherit
> + (simple-operating-system
> + (dhcp-client-service)
> + (service mongodb-service-type)
> + (extra-special-file "/etc/os-release"
> + (plain-file "os-release" "guix\n"))))
Does it require that ‘os-release’ file? If so, should the service add
it? That would probably intrusive though, so it’s even better if
MongoDB does not require it.
> + (test-eq "can connect"
> + 0
> + (system* (string-append #$mongodb "/bin/mongo")
> + "test"
> + "--eval"
> + "help"))
If it’s easy to do through the CLI, it might be worth trying insert an
element and query it.
> +%mongodb-os
Leftover.
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2017-08-31 12:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 9:18 [bug#28198] [PATCH] Add MongoDB package and service Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 1/4] vm: Add disk-image-size to <virtual-machine> Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 2/4] gnu: Add mongodb Christopher Baines
2017-08-31 12:32 ` Ludovic Courtès
2017-09-30 8:04 ` Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 3/4] services: Add MongoDB Christopher Baines
2017-08-31 12:34 ` Ludovic Courtès
2017-09-30 8:05 ` Christopher Baines
2017-08-23 9:25 ` [bug#28198] [PATCH 4/4] tests: databases: Add MongoDB test Christopher Baines
2017-08-31 12:37 ` Ludovic Courtès [this message]
2017-09-30 8:09 ` Christopher Baines
2017-08-31 12:29 ` [bug#28198] [PATCH 1/4] vm: Add disk-image-size to <virtual-machine> Ludovic Courtès
2017-09-25 20:36 ` Christopher Baines
2017-09-26 7:14 ` Ludovic Courtès
2017-09-29 6:48 ` [bug#28635] " Christopher Baines
2017-08-26 22:33 ` [bug#28198] [PATCH] Add MongoDB package and service Roel Janssen
2017-08-27 22:30 ` Christopher Baines
2017-09-30 7:59 ` [bug#28198] [PATCH 1/3] vm: Add disk-image-size to <virtual-machine> Christopher Baines
2017-09-30 7:59 ` [bug#28198] [PATCH 2/3] gnu: Add mongodb Christopher Baines
2017-10-04 14:40 ` Ludovic Courtès
2017-09-30 7:59 ` [bug#28198] [PATCH 3/3] services: Add MongoDB Christopher Baines
2017-10-04 14:44 ` Ludovic Courtès
2017-10-06 20:29 ` bug#28198: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8wnud46.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28198@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.