all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 28913@debbugs.gnu.org
Subject: [bug#28913] [PATCH 2/2] gnu: Add criu.
Date: Sun, 22 Oct 2017 15:39:44 -0700	[thread overview]
Message-ID: <87h8uqyfgv.fsf@gnu.org> (raw)
In-Reply-To: <20171021005556.28993-2-rekado@elephly.net> (Ricardo Wurmus's message of "Sat, 21 Oct 2017 02:55:56 +0200")

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/virtualization.scm (criu): New variable.

[...]

> +         (replace 'configure
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             ;; The includes for libnl are located in a sub-directory.
> +             (setenv "C_INCLUDE_PATH"
> +                     (string-append (assoc-ref inputs "libnl")
> +                                    "/include/libnl3:"
> +                                    (getenv "C_INCLUDE_PATH")))

And there’s no libnet.pc or similar to provide the right -I flag?

> +    (synopsis "Checkpoint and restore in userspace")

“user space” (two words)?

Otherwise LGTM, thank you!

Ludo’.

  reply	other threads:[~2017-10-22 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18 19:09 [bug#28913] gnu: Add criu Ricardo Wurmus
2017-10-21  0:55 ` [bug#28913] [PATCH 1/2] gnu: Add libnet Ricardo Wurmus
2017-10-21  0:55   ` [bug#28913] [PATCH 2/2] gnu: Add criu Ricardo Wurmus
2017-10-22 22:39     ` Ludovic Courtès [this message]
2017-10-23  6:07       ` Ricardo Wurmus
2017-10-23  6:10         ` bug#28913: " Ricardo Wurmus
2017-10-23 16:25         ` [bug#28913] " Ludovic Courtès
2017-10-22 22:38   ` [bug#28913] [PATCH 1/2] gnu: Add libnet Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8uqyfgv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28913@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.