From: Marius Bakke <mbakke@fastmail.com>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 30492@debbugs.gnu.org
Subject: [bug#30492] [PATCH 3/4] gnu: Add wxwidgets@2.8.
Date: Mon, 19 Feb 2018 01:24:18 +0100 [thread overview]
Message-ID: <87h8qdddxp.fsf@fastmail.com> (raw)
In-Reply-To: <20180218223344.5a7de7ca@alma-ubu>
[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:
> On Sun, 18 Feb 2018 18:07:38 +0100
> Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:
>>
>> > * gnu/packages/wxwidgets.scm (wxwidgets-2.8): New variable.
>>
>> This is effectively a revert of
>> 6f9ba4c91c096a2fb95da111be0657d99ef2b683. However, it does some
>> things differently, can you have a look and see if this patch needs
>> adjustment?
>>
>> [...]
>>
>> > +(define-public wxwidgets-2.8
>> > + (package (inherit wxwidgets)
>> > + (version "2.8.12")
>> > + (source
>> > + (origin
>> > + (method url-fetch)
>> > + (uri (string-append
>> > "https://github.com/wxWidgets/wxWidgets/archive/v"
>> > + version ".tar.gz"))
>>
>> wxWidgets provides "release" tarballs which are preferred to the
>> auto-generated git archive tarballs. See the above-mentioned commit
>> for the proper URL :-)
>
> Thanks Marius for reviewing that series.
>
> I did not know that there was already a 2.8-version and haven't looked
> into history. I copied the non-release URL from 3.1, which isn't
> released yet :-)
>
> I think I will just revert the commit you mentioned, as this worked
> and was there in the past. How do I revert that, concerning the commit
> message: Do I write a full, normal commmit like
> "gnu/package/wxwidgets.scm: Add new variable"? Should I mention the
> revert? Is it legitimate/necessary to add my copyright header,
> although I haven't contributed any line?!
Just the commit generated by "git revert" is fine IMO.
Thanks for packaging these!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-02-19 0:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 21:09 [bug#30492] [PATCH 0/4] Add libspatialite and spatialite-gui Björn Höfling
2018-02-16 21:18 ` [bug#30492] [PATCH 1/4] gnu: Add libspatialite Björn Höfling
2018-02-18 17:03 ` Marius Bakke
2018-02-19 17:34 ` Arun Isaac
2018-02-19 17:44 ` Björn Höfling
2018-02-16 21:19 ` [bug#30492] [PATCH 2/4] gnu: Add libgaiagraphics Björn Höfling
2018-02-18 17:03 ` Marius Bakke
2018-02-16 21:20 ` [bug#30492] [PATCH 3/4] gnu: Add wxwidgets@2.8 Björn Höfling
2018-02-18 17:07 ` Marius Bakke
2018-02-18 21:33 ` Björn Höfling
2018-02-19 0:24 ` Marius Bakke [this message]
2018-02-16 21:20 ` [bug#30492] [PATCH 4/4] gnu: Add spatialite-gui Björn Höfling
2018-02-18 17:08 ` Marius Bakke
2018-02-21 23:01 ` [bug#30492] [PATCH v2 0/4] Add libspatialite and spatialite-gui Björn Höfling
2018-02-21 23:07 ` [bug#30492] [PATCH v2 1/4] gnu: Add libspatialite Björn Höfling
2018-02-21 23:08 ` [bug#30492] [PATCH v2 2/4] gnu: Add libgaiagraphics Björn Höfling
2018-02-21 23:09 ` [bug#30492] [PATCH v2 3/4] Revert "gnu: Remove wxwidgets@2.8." Björn Höfling
2018-02-21 23:10 ` [bug#30492] [PATCH v2 4/4] gnu: Add spatialite-gui Björn Höfling
2018-02-22 13:39 ` bug#30492: [PATCH v2 0/4] Add libspatialite and spatialite-gui Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8qdddxp.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30492@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.