From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 33185@debbugs.gnu.org
Subject: [bug#33185] [PATCH 6/7] gnu: Add patchwork.
Date: Mon, 19 Nov 2018 17:37:43 +0100 [thread overview]
Message-ID: <87h8gdxbu0.fsf@gnu.org> (raw)
In-Reply-To: <20181104104455.3527-6-mail@cbaines.net> (Christopher Baines's message of "Sun, 4 Nov 2018 10:44:54 +0000")
Christopher Baines <mail@cbaines.net> skribis:
> ---
> gnu/packages/patchutils.scm | 103 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 103 insertions(+)
[...]
> + (add-after 'unpack 'patch-wsgi.py
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (substitute* "patchwork/wsgi.py"
> + (("import os")
> + (string-append
> + "import os, sys
> +
> +sys.path.extend('" (string-append (getenv "PYTHONPATH") ":" (site-packages inputs outputs)) "'.split(':'))"))
> + (("'patchwork\\.settings\\.production'")
> + "os.getenv('DJANGO_SETTINGS_MODULE', 'guix.patchwork.settings')"))))
> + (replace 'check
> + (lambda* (#:key tests? #:allow-other-keys)
> + (or (not tests?)
> + (begin
> + (setenv "DJANGO_SETTINGS_MODULE" "patchwork.settings.dev")
> + (invoke
> + "python" "-Wonce" "./manage.py" "test" "--noinput")
> + #t))))
> + (replace 'install
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (for-each (lambda (directory)
> + (copy-recursively
> + directory
> + (string-append (site-packages inputs outputs)
> + "/" directory)))
> + '("patchwork"
> + "templates"))
> + (delete-file-recursively (string-append
> + (site-packages inputs outputs)
> + "patchwork/tests"))
> + (let ((static-root
> + (string-append out "/share/patchwork/htdocs")))
> + (mkdir-p static-root)
> + (copy-file "patchwork/settings/production.example.py"
> + "patchwork/settings/assets.py")
> + (setenv "DJANGO_SECRET_KEY" "dummyvalue")
> + (setenv "DJANGO_SETTINGS_MODULE" "patchwork.settings.assets")
> + (setenv "STATIC_ROOT" static-root)
> + (invoke "./manage.py" "collectstatic" "--no-input"))
> +
> + (copy-recursively "lib"
> + (string-append
> + out "/share/doc/" ,name "-" ,version)))
> + #t))
> + (add-after 'install 'install-patchwork-admin
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/bin"))
> + (call-with-output-file (string-append out "/bin/patchwork-admin")
> + (lambda (port)
> + (display "#!/usr/bin/env python3
> +import os, sys
> +
> +if __name__ == \"__main__\":
> + os.environ.setdefault(
> + \"DJANGO_SETTINGS_MODULE\",
> + \"guix.patchwork.settings\"
> + )
> +
> + from django.core.management import execute_from_command_line
> +
> + execute_from_command_line(sys.argv)" port)))
> + (chmod (string-append out "/bin/patchwork-admin") #o555))
> + #t)))))
IMO these phases would be less intimidating with a few comments
explaining what’s going on. :-)
> + (synopsis "")
> + (description "")
> + (home-page "")
> + (license "")))
As swedebugia noted, you’re missing a few things here and in the commit
log. :-)
With these things fixed it should be good!
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-11-19 16:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 9:21 [bug#33185] [PATCH 0/7] Add patchwork package and service Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 1/7] gnu: Add python-jsmin Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 2/7] gnu: Add python-slimit Christopher Baines
2018-11-19 16:30 ` Ludovic Courtès
2018-11-20 19:58 ` Christopher Baines
2018-10-28 9:26 ` [bug#33185] [PATCH 3/7] gnu: Add python-django-pipeline Christopher Baines
2018-11-19 16:30 ` Ludovic Courtès
2018-10-28 9:26 ` [bug#33185] [PATCH 4/7] gnu: Add python-django-jinja Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 5/7] gnu: Add python-django-debug-toolbar Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 6/7] gnu: Add patchwork Christopher Baines
2018-10-28 9:27 ` [bug#33185] [PATCH 7/7] services: " Christopher Baines
2018-11-19 16:29 ` [bug#33185] [PATCH 1/7] gnu: Add python-jsmin Ludovic Courtès
2018-11-04 10:44 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 2/7] gnu: Add python-slimit Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 3/7] gnu: Add python-django-pipeline Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 4/7] gnu: Add python-django-jinja Christopher Baines
2018-11-19 16:33 ` Ludovic Courtès
2018-11-20 20:02 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 5/7] gnu: Add python-django-debug-toolbar Christopher Baines
2018-11-19 16:33 ` Ludovic Courtès
2018-11-20 20:03 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 6/7] gnu: Add patchwork Christopher Baines
2018-11-04 19:09 ` swedebugia
2019-01-22 22:36 ` Christopher Baines
2018-11-19 16:37 ` Ludovic Courtès [this message]
2019-01-22 22:31 ` Christopher Baines
2018-11-04 10:44 ` [bug#33185] [PATCH 7/7] services: " Christopher Baines
2018-11-04 19:10 ` swedebugia
2018-11-19 16:42 ` Ludovic Courtès
2018-11-20 18:22 ` Christopher Baines
2018-11-20 18:06 ` Christopher Baines
2019-01-22 22:09 ` [bug#33185] [PATCH v2 1/2] gnu: " Christopher Baines
2019-01-22 22:09 ` [bug#33185] [PATCH v2 2/2] services: " Christopher Baines
2019-01-22 22:40 ` Christopher Baines
2019-01-23 9:28 ` [bug#33185] [PATCH v2 1/2] gnu: " Ricardo Wurmus
2019-01-25 21:04 ` Christopher Baines
2019-01-25 21:00 ` [bug#33185] [PATCH v3 " Christopher Baines
2019-01-25 21:00 ` [bug#33185] [PATCH v3 2/2] services: " Christopher Baines
2019-05-03 19:16 ` [bug#33185] [PATCH 0/7] Add patchwork package and service Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 1/3] services: Add getmail Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 2/3] gnu: Add patchwork Christopher Baines
2019-05-03 19:30 ` [bug#33185] [PATCH 3/3] services: " Christopher Baines
2019-05-31 19:43 ` bug#33185: [PATCH 0/7] Add patchwork package and service Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8gdxbu0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33185@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.