all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Move r-{desolve, quadprog, pracma, subplex} from maths.scm to cran.scm
Date: Tue, 10 Dec 2019 09:41:31 +0100	[thread overview]
Message-ID: <87h8286090.fsf@elephly.net> (raw)
In-Reply-To: <CAJ3okZ21qB0DpnegmDoMvEOV=FP4ktdb5EihCJMOSFWRAsrQcg@mail.gmail.com>


zimoun <zimon.toutoune@gmail.com> writes:

> 1.
> Currently, the file bioconductor.scm contains 4 packages with
> 'cran-uri' and git blames you. :-)
>
> Well, the 4 commits are:
>
> : a207bca2ad gnu: r-codedepends: Move from cran to bioconductor.
> : 3a0babacdc gnu: Add r-htscluster.
> : 7ed869f796 gnu: Add r-nbpseq.
> : 80eb01c776 gnu: r-gkmsvm: Move to (gnu packages bioconductor).
>
> with some comments  as
>
> --8<---------------cut here---------------start------------->8---
> ;; This is a CRAN package, but it uncharacteristically depends on a
> ;; Bioconductor package
> --8<---------------cut here---------------end--------------->8---
>
> Do you remember a special motivation?

Yes, the comments say why.  It’s very unusual for a CRAN package to
depend on Bioconductor packages.  Usually, it is the other way around.
I just didn’t want (gnu packages cran) to point to (gnu packages
bioconductor).  A more correct way to deal with this would be put these
outliers in a separate module, or even to ignore this all together until
it becomes a problem.

> 2.
> The second point is that the file statistics.scm contains 227 packages
> and 206 are cran-uri. And the file cran.scm already contains 602
> packages, so it will be almost as python-xyz.scm is. Why not. Then,
> this file statistics.scm will be almost empty and I propose instead to
> populate the files maths.scm, python-xyz.scm.
>
> What do you think?

statistics.scm was the only thing we had for R in the beginning.  When
it grew and it became apparent that more and more CRAN packages would be
added, I felt that the module became less suitable.

I don’t understand your comment about “maths.scm” and “python-xyz.scm”.
I think it’s good to move CRAN and Bioconductor packages out of
statistics.scm whenever possible.  We can leave the actual statistics
programs there as well as potentially unmovable CRAN packages.

> 3.
> It is a big move. Do you prefer
>  - a commit per package, so more or less 300 commits?
>  - or a commit bioconductor.scm->cran.scm, another
> statistics.scm->cran.scm, bioinformatics.scm->bioconductor.scm and
> bioconductor->bioinformatics.scm, etc.?

I prefer one commit per moved package.  I guess this is not what you
hoped for, but it makes for a more fine-grained log — and it boosts your
commit stats ;)

--
Ricardo

  reply	other threads:[~2019-12-10  8:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 15:37 Move r-{desolve,quadprog,pracma,subplex} from maths.scm to cran.scm zimoun
2019-11-07 19:08 ` Move r-{desolve, quadprog, pracma, subplex} " zimoun
2019-11-07 22:42   ` Ricardo Wurmus
2019-11-22 14:47 ` Ricardo Wurmus
2019-11-22 16:03   ` zimoun
2019-12-09 23:25   ` zimoun
2019-12-10  8:41     ` Ricardo Wurmus [this message]
2019-12-10 12:17       ` zimoun
2019-12-10 15:38         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8286090.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.