From: "Ludovic Courtès" <ludo@gnu.org>
To: Thomas Albers <thomas@thomaslabs.org>
Cc: 49643@debbugs.gnu.org
Subject: [bug#49643] [PATCH] z80asm and z80dasm
Date: Wed, 11 Aug 2021 16:23:44 +0200 [thread overview]
Message-ID: <87h7fwkqkv.fsf@gnu.org> (raw)
In-Reply-To: <87v956mrzv.fsf@thomaslabs.org> (Thomas Albers's message of "Mon, 19 Jul 2021 14:02:12 +0200")
Hi Thomas,
Sorry for the long delay replying. Overall the patch LGTM, though there
are minor issues that ‘guix lint’ should report and others related to
the guidelines:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
In particular, could you send one patch per package (ideally with proper
commit log, preferably with ‘git send-email’), with
synopses/descriptions tweaked according to the guidelines?
You can send revised patches to 49643@debbugs.gnu.org.
Thanks in advance,
Ludo’.
next prev parent reply other threads:[~2021-08-11 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 12:02 [bug#49643] [PATCH] z80asm and z80dasm Thomas Albers via Guix-patches via
2021-08-11 14:23 ` Ludovic Courtès [this message]
2021-08-13 14:46 ` Thomas Albers via Guix-patches via
2021-08-11 18:20 ` [bug#49643] [PATCH] gnu: Add z80asm Thomas Albers via Guix-patches via
2021-08-13 14:31 ` [bug#49643] [PATCH 1/2] " Thomas Albers via Guix-patches via
2021-08-13 14:31 ` [bug#49643] [PATCH 2/2] gnu: Add z80dasm Thomas Albers via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7fwkqkv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=49643@debbugs.gnu.org \
--cc=thomas@thomaslabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.