all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: poptsov.artyom@gmail.com (Artyom V. Poptsov)
Cc: 52799@debbugs.gnu.org
Subject: [bug#52799] [PATCH] gnu: guile-udev: Update to 0.2.1
Date: Sun, 26 Dec 2021 16:23:26 +0100	[thread overview]
Message-ID: <87h7avqtjl.fsf@gnu.org> (raw)
In-Reply-To: <874k6v6a54.fsf@gmail.com> (Artyom V. Poptsov's message of "Sun,  26 Dec 2021 11:30:31 +0300")


Hey Artyom,

You may prefer to use AC_PATH_PROG to locate guile_snarf, you can have a
look the configure.ac file of Guile-Avahi for instance.

> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch
> +                    (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      (substitute* "build-aux/am/snarf"
> +                        (("\\$\\(shell whereis guile-snarf \\| cut -d' ' -f2\\)")
> +                         (format #f "~a/bin/guile-snarf"
> +                                 (assoc-ref inputs "guile")))))))))

Otherwise, outputs seems to be unused in this snippet. We also now try
to avoid relying on inputs labels. So using "search-input-file" or
(string-append #$(this-package-input guile) "/bin/snarf") would be
preferred.

You can have a look to:
https://guix.gnu.org/en/blog/2021/the-big-change/ for more details.

Thanks,

Mathieu




  reply	other threads:[~2021-12-26 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26  8:30 [bug#52799] [PATCH] gnu: guile-udev: Update to 0.2.1 Artyom V. Poptsov
2021-12-26 15:23 ` Mathieu Othacehe [this message]
2022-04-24 16:39 ` bug#52799: " Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7avqtjl.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=52799@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.