all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 67733@debbugs.gnu.org
Subject: [bug#67733] [PATCH v3] daemon: Sacrifice builders on OOM.
Date: Sun, 10 Dec 2023 22:51:15 +0100	[thread overview]
Message-ID: <87h6kp3ewc.fsf@gnu.org> (raw)
In-Reply-To: <20231203000111.30681-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Sun, 3 Dec 2023 01:00:01 +0100")

Hullo!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * nix/libstore/build.cc (DerivationGoal::runChild):
> Maximise our OOM score adjustment.
>
> Change-Id: I418c763b499ca16e1ffe3c6033319112b9744f51
> ---
>
> v3: In my defens, I'm on a fone.

Nooo, you’re a hero.

> +	/* Ask the kernel to eagerly kill us & our children if it runs out of
> +	   memory, regardless of blame, to preserve ‘real’ user data & state. */
> +	try {
> +	    writeFile("/proc/self/oom_score_adj", "1000"); // 100%
> +	} catch (...) { ignoreException(); }

Sounds like a good idea.  LGTM!

Ludo’.




  reply	other threads:[~2023-12-10 21:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03  0:00 [bug#67733] [PATCH] daemon: Sacrifice builders on OOM Tobias Geerinckx-Rice via Guix-patches via
2023-12-03  0:00 ` [bug#67733] [PATCH v3] " Tobias Geerinckx-Rice via Guix-patches via
2023-12-10 21:51   ` Ludovic Courtès [this message]
2023-12-03  0:00 ` [bug#67733] [PATCH v2] " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6kp3ewc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=67733@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.