all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@posteo.net>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Package variation
Date: Wed, 24 Oct 2018 01:01:22 -0500	[thread overview]
Message-ID: <87ftwvj32l.fsf@posteo.net> (raw)
In-Reply-To: <878t2oul96.fsf@gmail.com>


Chris Marusich writes:

> Hi Brett,
>
> Brett Gilio <brettg@posteo.net> writes:
>
>> (define-public gnome-custom
>>   (package (inherit gnome)
>>     (name "gnome-custom")
>>     (inputs (alist-delete "nautilus" (package-inputs gnome)))))
>
> The spirit of this is correct, but the implementation isn't quite
> right.  The gnome package has no inputs:
>
>   scheme@(guile-user)> ,use (gnu packages gnome)
>   scheme@(guile-user)> ,use (guix packages)
>   scheme@(guile-user)> (package-inputs gnome)
>   $1 = ()
>
> Instead, it has many propagated inputs.  So, you should probably write:
>
>   (define-public gnome-custom
>     (package (inherit gnome)
>       (name "gnome-custom")
>       (propagated-inputs (alist-delete
>                            "nautilus"
>                            (package-propagated-inputs gnome)))))
>
> This will work as you expect.  It's not incorrect to use alist-delete
> here, but FYI you can also use matching to do this as follows:
>
>   (define-public gnome-custom
>     (package (inherit gnome)
>       (name "gnome-custom")
>       (propagated-inputs (remove
>                            (match-lambda
>                              ;; Ignore the second value.
>                              ((name _)
>                               (string=? name "nautilus")))
>                            (package-propagated-inputs gnome)))))
>
> Whether or not you like that better probably depends on whether or not
> you view the value returned by (package-propagated-inputs gnome) as an
> alist or a list of 2-element lists.
>
>> (services (cons* (service gnome-desktop-service-type
>> 			    config =>
>> 			    (gnome-desktop-configuration
>> 			     (inherit config)
>> 			     (gnome-package gnome-custom)))
>> 		   %desktop-services))
>
> It looks like you're using "config =>" from the modify-services syntax
> without actually using modify-services.  Try this instead:
>
>   (services (cons* (service gnome-desktop-service-type
>                             (gnome-desktop-configuration
>                               (inherit config)
>                               (gnome-package gnome-custom)))
>                    %desktop-services))
>
> This should create and add a gnome-desktop-service-type service instance
> with the configuration you've specified.
>
> Hope that helps!


Hi chris! Thank you for your feedback, and your insight. I appreciate it
greatly. I have applied your changes (Both variations) and neither one
seems to be working and nautilus remains on the system. I am honestly at
a loss of what is wrong with the approach.

  reply	other threads:[~2018-10-24  6:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  6:51 Package variation Brett Gilio
2018-10-23  7:33 ` Efraim Flashner
2018-10-23 18:04   ` Brett Gilio
2018-10-23 18:13     ` Efraim Flashner
2018-10-23 19:50       ` Brett Gilio
2018-10-24  2:33     ` Chris Marusich
2018-10-24  6:01       ` Brett Gilio [this message]
2018-10-25  5:35         ` Chris Marusich
2018-10-24 13:06 ` Ludovic Courtès
2018-10-24 21:02   ` Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftwvj32l.fsf@posteo.net \
    --to=brettg@posteo.net \
    --cc=cmmarusich@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.