all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 34086@debbugs.gnu.org
Subject: [bug#34086] [PATCH] Add StepMania
Date: Wed, 23 Jan 2019 10:40:31 +0100	[thread overview]
Message-ID: <87fttjiueo.fsf@gnu.org> (raw)
In-Reply-To: <87muns1i8t.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 22 Jan 2019 22:42:58 +0100")

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> From 00196d57d6987ed4e93d5cd51af3a4c2d20cc7f3 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 11 Nov 2018 00:43:34 +0100
> Subject: [PATCH] gnu: Add stepmania.
>
> * gnu/packages/games.scm (stepmania):
> * gnu/packages/video.scm (ffmpeg-for-stepmania): New variables.

[...]

> +(define-public ffmpeg-for-stepmania
> +  (hidden-package
> +   (inherit ffmpeg)
> +   (version "2.1.3")

I’m pretty sure this doesn’t evaluate, does it?  :-)

Should be:

  (hidden-package
    (package
      (inherit ffmpeg)
      …))

Apart from that, could you please add the explanation and/or a link to
an upstream discussion summarizing what you described regarding this
choice of a custom FFMpeg variant?

OK with this changes!

Thanks,
Ludo’.

  reply	other threads:[~2019-01-23  9:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 18:10 [bug#34086] [PATCH] Add StepMania Nicolas Goaziou
2019-01-20 18:09 ` Ludovic Courtès
2019-01-22  8:33   ` Nicolas Goaziou
2019-01-22 19:24     ` Leo Famulari
2019-01-22 21:42       ` Nicolas Goaziou
2019-01-23  9:40         ` Ludovic Courtès [this message]
2019-01-25 17:10           ` Nicolas Goaziou
2019-01-23 21:34         ` Leo Famulari
2019-01-25 17:41           ` bug#34086: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fttjiueo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=34086@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.