From: Christopher Baines <mail@cbaines.net>
To: 39109@debbugs.gnu.org, Kei Kebreau <kkebreau@posteo.net>
Subject: [bug#39109] [PATCH] gnu: red-eclipse: Update to 2.0.0.
Date: Mon, 13 Jan 2020 22:31:35 +0000 [thread overview]
Message-ID: <87ftgjc7js.fsf@cbaines.net> (raw)
In-Reply-To: <20200113013240.28578-1-kkebreau@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
Kei Kebreau <kkebreau@posteo.net> writes:
> * gnu/packages/games.scm (red-eclipse): Update to 2.0.0.
> [source]: Remove obsolete patch, and fetch submodules making recursive true.
> [arguments]: Remove "unpack-data" phase and adjust
> "add-store-data-package-path-as-default" phase.
> [inputs]: Add freetype and remove data-sources.
> * gnu/packages/patches/red-eclipse-remove-gamma-name-hack.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): Delete file.
> ---
> gnu/local.mk | 1 -
> gnu/packages/games.scm | 96 +++----------------
> .../red-eclipse-remove-gamma-name-hack.patch | 52 ----------
> 3 files changed, 12 insertions(+), 137 deletions(-)
> delete mode 100644 gnu/packages/patches/red-eclipse-remove-gamma-name-hack.patch
Looks good to me :) The changes look good, I like that the package
definition is a little shorter. I've successfully built the package on
x86_64-linux, and launched the game.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-01-13 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 1:32 [bug#39109] [PATCH] gnu: red-eclipse: Update to 2.0.0 Kei Kebreau
2020-01-13 22:31 ` Christopher Baines [this message]
2020-01-16 3:47 ` bug#39109: " Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftgjc7js.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=39109@debbugs.gnu.org \
--cc=kkebreau@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.